bazel: 0.18.0 -> 0.20.0 #51783
Merged
bazel: 0.18.0 -> 0.20.0 #51783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lCheckPhase. This change is going to be required when upgrading to Bazel 0.20.0, because in the checkPhase we're not wrapping the Bazel binary yet to set some necessary default arguments.
This package is redundant, since Bazel (since the upgrade to v0.20.0), now uses JDK 11 as the runtime JDK.
uri-canva
reviewed
Dec 14, 2018
| @@ -8259,10 +8259,6 @@ in | |||
| bazel = callPackage ../development/tools/build-managers/bazel { | |||
| inherit (darwin) cctools; | |||
| inherit (darwin.apple_sdk.frameworks) CoreFoundation CoreServices Foundation; | |||
| }; | |||
| bazel_jdk11 = callPackage ../development/tools/build-managers/bazel { | |||
There was a problem hiding this comment.
There might not be a need for the runJdk parameter after this.
There was a problem hiding this comment.
Wouldn’t it still be a useful distinction to have both runJdk and buildJdk, even if they are effectively the same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the removal of the
bazel_jdk11package, which isnow redundant with the
bazelpackage.