Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monero: build with hidapi #51782

Merged
merged 1 commit into from Dec 12, 2018
Merged

monero: build with hidapi #51782

merged 1 commit into from Dec 12, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Dec 9, 2018 •
edited

Motivation for this change

Fix #51726

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 9, 2018

@thedavidmeister Can you tell me if everything works for you?

@thedavidmeister
Copy link
Contributor

@rnhmjoj what is the best way to test?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 10, 2018

@thedavidmeister the easiest way would be nix-shell -p nox --run 'nox-review pr 51782'. It should build the package and print the store path of the result.

@thedavidmeister
Copy link
Contributor

@rnhmjoj oh that's really cool! i didn't know i could do that, i'll test it out sometime this week hopefully

@fpletz fpletz self-assigned this Dec 11, 2018
@Mic92 Mic92 merged commit abbd29a into NixOS:master Dec 12, 2018
@thedavidmeister
Copy link
Contributor

oh wow, it's in, nom nom

i'll test against master then i suppose >.<

@rnhmjoj rnhmjoj deleted the monero branch February 23, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fpletz fpletz

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rnhmjoj @thedavidmeister @Mic92 @fpletz @GrahamcOfBorg