Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distrobuilder: 2018_06_29 -> 2018_10_04 #51788

Merged
merged 1 commit into from Dec 11, 2018
Merged

distrobuilder: 2018_06_29 -> 2018_10_04 #51788

merged 1 commit into from Dec 11, 2018

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented Dec 9, 2018 •
edited

Motivation for this change

Upgrade distrobuilder

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Dec 11, 2018

@GrahamcOfBorg build distrobuilder

@srhb srhb merged commit 6449501 into NixOS:master Dec 11, 2018
@megheaiulian megheaiulian deleted the feature/distrobuilder branch December 17, 2018 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@megheaiulian @srhb @GrahamcOfBorg