-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually implement IAU 29 resolution B3 #2024
Conversation
constexpr GravitationalParameter TerrestrialGravitationalParameter = | ||
3.986'004e14 * (Pow<3>(si::Metre) / Pow<2>(si::Second)); | ||
constexpr GravitationalParameter JovianGravitationalParameter = | ||
1.266'865'3e17 * (Pow<3>(si::Metre) / Pow<2>(si::Second)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have grouped all the parameters for a planet together: equatorial radius/polar radius/gravitational parameter separated by a blank line. I would also have alphabetized the planets (thus Jovian < Terrestrial).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, let's keep the order used by the IAU tables.
reference_angle : "0 deg" | ||
angular_frequency : "109.256 deg / d" | ||
name : "Trappist-1" | ||
gravitational_parameter : "0.0890 GM☉" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this pull request does not regenerate the cfg
files, as the tools would copy over 0.0890 GM☉
and the like instead of converting to SI units, which would cause interchange issues for strings passed in structs.
We want to rerun the optimization soon anyway.
While #1846 introduced a reference to the IAU resolution, it kept the existing constants.
These are ancient, introduced by 3084f81 in March 2014, predating the relevant IAU resolution by more than a year; being masses, they are fundamentally unsuitable as nominal values, as gravitational parameters are known with much greater accuracy than 𝐺 is.
Switch to the system of nominal solar and planetary conversion constants.