Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glu: don't use valgrind on darwin #51784

Merged
merged 1 commit into from Dec 11, 2018
Merged

glu: don't use valgrind on darwin #51784

merged 1 commit into from Dec 11, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Dec 9, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rasendubi
Copy link
Member

This causes a rebuild of about 4300+ packages on linux. Should go to staging first.

@LnL7 LnL7 changed the base branch from master to staging December 11, 2018 21:39
@LnL7
Copy link
Member Author

LnL7 commented Dec 11, 2018

Yeah, wanted to make sure it wasn't important enough that a darwin only rebuild was necessary to unblock master.

@LnL7 LnL7 merged commit 3a621ab into NixOS:staging Dec 11, 2018
@LnL7 LnL7 deleted the darwin-glu branch December 16, 2018 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants