-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CKAN identifiers for RCSBuildAid and HangarExtender #932
Conversation
@DrRaphello are you sure those are the proper identifiers for the 1.3.1 versions of those mods? I thought I had checked them (but there is a good chance I missed it or pulled old stuff) |
@pap1723 Yes, I've just double checked on NetKAN - both were renamed when taken over by LGG and updated to 1.3 |
One more question - is dmagic orbital science a hard dependency now? |
Yes it is. Many of the new science parts are modified versions of the
DMagic Orbital stuff.
…On Sun, Dec 9, 2018 at 10:41 AM DrRaphello ***@***.***> wrote:
One more question - is dmagic orbital science a hard dependency now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#932 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ASjbf0WhYitanlcNL-5OO0-aObhy8Tvrks5u3T0fgaJpZM4ZKLSj>
.
|
not sure how but can the links be made virtual so if the original is restored (like FAR vs FAR cont. in RO now) you can use either? |
Great if it can, but I don't enough about CKAN.
…On Sun, Dec 9, 2018, 1:11 PM Bornholio ***@***.*** wrote:
not sure how but can the links be made virtual so if the original is
restored (like FAR vs FAR cont. in RO now) you can use either?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#932 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ASjbf638NzxVCL82YYx8yl5xqcmOPGMBks5u3WBbgaJpZM4ZKLSj>
.
|
hmm, I can see nothing in RO netkan file that does such a substitution. They seem to have a pretty standard definition: "depends" : [ { "name" : "FerramAerospaceResearch" }. I have not found any obvious solution in netkan specification either. |
it seems possible for FAR but not for these two mods: link |
So, is seems possible after all based on further response from HebaruSan. However, I see possibility of old mod version revival so low that it does not make sense to ask him and LGG to spend time on this. |
Couldn't we leave both the old one and the new one as links? That way if the old one is ever reactivated, LGG drops the new one. Any drawbacks to this? |
We could do this too. The only risk is an unlikely scenario where both original dev and LGG continue their separate versions. |
Commited directly to master as it affects the main netkan read by CKAN |
No description provided.