Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: kubernetes: use /run instead of /var/run #51801

Closed
wants to merge 1 commit into from
Closed

nixos: kubernetes: use /run instead of /var/run #51801

wants to merge 1 commit into from

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented Dec 9, 2018 •
edited

Motivation for this change

Currently tmpfiles is giving a warning upon nixos-rebuild switch like the following:

setting up tmpfiles
[/etc/tmpfiles.d/nixos.conf:6] Line references path below legacy directory /var/run/, updating /var/run/kubernetes → /run/kubernetes; please update the tmpfiles.d/ drop-in file accordingly.

/etc/tmpfiles.d/nixos.conf:6:

d /var/run/kubernetes 0755 kubernetes kubernetes -

This PR changes the directory from /var/run/kubernetes to /run/kubernetes.

Related #51800

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 9, 2018

@GrahamcOfBorg test kubernetes

@bobvanderlinden
Copy link
Member Author

There is already a PR that attempts to solve this for all packages: #47856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobvanderlinden @Mic92 @GrahamcOfBorg