Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptables: prune libtool files after build #51787

Merged
merged 1 commit into from Dec 10, 2018
Merged

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Dec 9, 2018

Motivation for this change

Follow-up to #51252 / cc @hedning
Otherwise -lpcap gets propagated to reverse deps
This can break strongswan build for example
#51252 (comment)

Now the .la files contains

# Libraries that this one depends upon.
dependency_libs='' #pruned

(also replaced the one local patch since it is now fixed upstream by combining 2 commits)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Otherwise -lpcap gets propagated to reverse deps
This can break strongswan build for example
NixOS#51252 (comment)
@hedning
Copy link
Contributor

hedning commented Dec 9, 2018

cc #51767 as @orivej mentioned enabling pruneLibtoolFiles by default.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Dec 9, 2018

(built locally even though it timeouts on ofborg)

@GrahamcOfBorg build strongswan

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Dec 10, 2018

I'm merging this so that it can be cherry-picked in staging-next

It won't prevent build if we decide to pruneLibtoolFiles by default later on.

@c0bw3b c0bw3b merged commit 00593d6 into NixOS:staging Dec 10, 2018
@c0bw3b c0bw3b deleted the pkg/iptables branch April 6, 2019 20:43
basvandijk added a commit to basvandijk/nixpkgs that referenced this pull request Apr 30, 2019
Since NixOS#51787 has been merged we can remove this ad-hoc fix.
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Apr 30, 2019
Since NixOS#51787 has been merged we can remove this ad-hoc fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants