EC2: add a physical property for 5th gen instances #1060
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems nice to have a new option under deployment.ec2.physicalProperties to flag 5th generation EC2 instances with Nitro cards, same a it's done for the ebsOptimized option, which instances require specific processing in certain areas. Example: EBS volumes are broadcasted as NVMe block devices named /dev/nvme[0..26]n1 thus cannot be mounted to /dev/xvd[f..z]. Feel free to change the naming, thanks !!
See: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html#ec2-nitro-instances
I also added a check here for 'tenancy' in product, otherwise the generate-ec2-properties.py would fail in entry HMJJY7J5YC97S5A2 which is a "CPU Credits" not a "Compute Instance" (line 6482 of the index.json): https://github.com/amemni/nixops/blob/f7eb86cbe4b9dcc531f35c7d27817965bcf96dd9/nix/generate-ec2-properties.py#L13