Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2: add a physical property for 5th gen instances #1060

Closed
wants to merge 1 commit into from

Conversation

amemni
Copy link
Contributor

@amemni amemni commented Dec 9, 2018

It seems nice to have a new option under deployment.ec2.physicalProperties to flag 5th generation EC2 instances with Nitro cards, same a it's done for the ebsOptimized option, which instances require specific processing in certain areas. Example: EBS volumes are broadcasted as NVMe block devices named /dev/nvme[0..26]n1 thus cannot be mounted to /dev/xvd[f..z]. Feel free to change the naming, thanks !!

See: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html#ec2-nitro-instances

I also added a check here for 'tenancy' in product, otherwise the generate-ec2-properties.py would fail in entry HMJJY7J5YC97S5A2 which is a "CPU Credits" not a "Compute Instance" (line 6482 of the index.json): https://github.com/amemni/nixops/blob/f7eb86cbe4b9dcc531f35c7d27817965bcf96dd9/nix/generate-ec2-properties.py#L13

@amemni amemni changed the title Add a deployment.ec2.physicalProperties option to differenciate Nitro-based (5th gen) EC2 instances with NVMe storage EC2: add a physical property for 5th gen instances Jan 10, 2019
@yorickvP
Copy link

This has the same problem as #971, ebsOptimized is gone for some instances.

@amemni amemni closed this Jan 24, 2019
@amemni amemni deleted the add-Nitro-physicalProperty branch January 24, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants