Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cernlib: fix build #51811

Merged
merged 2 commits into from Dec 10, 2018
Merged

cernlib: fix build #51811

merged 2 commits into from Dec 10, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 10, 2018

Motivation for this change

Fix the build after recent breakage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl
cernlib: fix build
357f6a8 
The imake rules contain a comment line that looks like a pragma. Recently imake
in nixpkgs was switched to use tradcpp, which is a bit more strict about
interpreting unknown pragmas. To fix the build, the comments is changed to use
C++ style comments.
@markuskowa
Copy link
Member

Is this package intended to run arm? Otherwise aarch64 could be removed from the platforms.

@veprbl
Copy link
Member Author

veprbl commented Dec 10, 2018

@markuskowa No idea. But let's disable it just to not bother aarch64 maintainers with this.

@markuskowa
Copy link
Member

From my experience many scientific HPC software packages have never been tested on arm. I think we are on the safe side restricting it to x86 for now.

@markuskowa markuskowa merged commit 07b5b55 into NixOS:master Dec 10, 2018
@veprbl veprbl deleted the pr/cernlib_fix branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @markuskowa @GrahamcOfBorg