Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncurses: fix cross-build by disable stripping #51779

Merged
merged 1 commit into from Dec 9, 2018
Merged

ncurses: fix cross-build by disable stripping #51779

merged 1 commit into from Dec 9, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 9, 2018 •
edited

Ncurses uses install -s to also strip the binaries while installing.
This broke the cross build because the wrong strip command was chosen.
Since we are stripping binaries in the fixupPhase anyway we can skip this as well.

cc @globin

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
ncurses: fix cross-build by disable stripping
ceaee84 
Ncurses uses `install -s` to also strip the binaries while installing.
This broke the cross build because the wrong strip command was chosen.
@Mic92
Copy link
Member Author

Mic92 commented Dec 9, 2018

@GrahamcOfBorg build ncurses

@Mic92
Copy link
Member Author

Mic92 commented Dec 9, 2018

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.ncurses

@Mic92 Mic92 merged commit 3278812 into NixOS:staging Dec 9, 2018
@Mic92 Mic92 deleted the ncurses branch December 9, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg