Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.virtualboxGuestAdditions: fix hash #51793

Merged
merged 1 commit into from Dec 9, 2018
Merged

linuxPackages.virtualboxGuestAdditions: fix hash #51793

merged 1 commit into from Dec 9, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Dec 9, 2018

Motivation for this change

Left over hash from #51669

Should unbreak the ova test on master.

cc @alyssais @markuskowa

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
Copy link
Contributor Author

hedning commented Dec 9, 2018

There's an update.py, though it seems to only spit out a json file with the correct hashes.

@markuskowa
Copy link
Member

@GrahamcOfBorg build nixosTests.virtualbox

@bachp
Copy link
Member

bachp commented Dec 9, 2018

@hedning The resulting JSON used to be the source of the hashes. But it got removed in c20cc6d.

@markuskowa
Copy link
Member

Thanks for fixing it!

@markuskowa markuskowa merged commit 2e0c3d2 into NixOS:master Dec 9, 2018
@hedning hedning deleted the fix-virtualboxGuestAdditions branch October 15, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hedning @markuskowa @bachp @GrahamcOfBorg