Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: switch release-18.09 to build with llvm7 #51789

Merged
merged 3 commits into from Dec 20, 2018

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Dec 9, 2018

Motivation for this change

Please merge when the next chromium rebuild is triggered in release-18.09 on hydra.

chromium in master has been clang for a cycle, so this should be safe to merge. However, right now, chromium is up to date in the release channel.

I'll leave this here, in case I'm not the one to merge the next chromium update.

see #51602

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bendlas bendlas added the 8.has: port to stable A PR already has a backport to the stable release. label Dec 9, 2018
@bendlas bendlas merged commit aa89b5f into NixOS:release-18.09 Dec 20, 2018
@bendlas bendlas deleted the release-18.09-chromium-llvm branch October 22, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants