Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6669 by adding missing command GetElementProperty #6670

Closed
wants to merge 2 commits into from

Conversation

hejhj
Copy link

@hejhj hejhj commented Nov 21, 2018


This change is Reviewable

@jimevans
Copy link
Member

Thank you for the contribution. I’m not going to blindly merge this without some thought. The next public release of the .NET bindings is going to be 4.0, and that won’t be released until running Chrome in spec-compliant mode can be the default, in which case, the corrected code included here would never be run.

@hejhj
Copy link
Author

hejhj commented Nov 22, 2018

Thank you for the contribution. I’m not going to blindly merge this without some thought. The next public release of the .NET bindings is going to be 4.0, and that won’t be released until running Chrome in spec-compliant mode can be the default, in which case, the corrected code included here would never be run.

right. Will close the pr.

@hejhj hejhj closed this Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants