Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GHCJS 8.4 #50879

Merged
merged 1 commit into from Nov 22, 2018
Merged

Bump GHCJS 8.4 #50879

merged 1 commit into from Nov 22, 2018

Conversation

ElvishJerricco
Copy link
Contributor

Motivation for this change

This change fixes a number of bugs in GHCJS 8.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ElvishJerricco ElvishJerricco mentioned this pull request Nov 21, 2018
Merged
9 tasks
@basvandijk
Copy link
Member

@GrahamcOfBorg build haskell.compiler.ghcjs84

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: haskell.compiler.ghcjs84

Partial log (click to expand)

cannot build derivation '/nix/store/j2pibcbj2g8zkphfsnh6bh91x3prkx1s-kan-extensions-5.2.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/a1rqz1cgh6x5crxvdpvsic0h0z196mf8-wai-extra-3.0.24.3.drv': 24 dependencies couldn't be built
cannot build derivation '/nix/store/5f81rnc60ahzfy53xk55b5n311jw3n7f-lens-4.16.1.drv': 34 dependencies couldn't be built
cannot build derivation '/nix/store/9n8573hs0n3jq708f6pvgkrw7paqca00-warp-3.2.25.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/pdph7zapank91fxkgd9g3yl92wwkq8nw-yaml-0.8.32.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/jl7dk8hfn2i72wvjqd7r8g578wskxi2y-wai-app-static-3.1.6.2.drv': 22 dependencies couldn't be built
cannot build derivation '/nix/store/ksw2qp3h72icwvmqqc33gz4xphkrw5br-wai-websockets-3.0.1.2.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/nx57lzkbasrz3qdvnai09my61gbf3ri8-ghcjs-8.4.0.1.drv': 51 dependencies couldn't be built
cannot build derivation '/nix/store/far2hwlsk9bvylbhd79h3ndrfk0vnwjd-ghcjs-8.4.0.1.drv': 4 dependencies couldn't be built
error: build of '/nix/store/far2hwlsk9bvylbhd79h3ndrfk0vnwjd-ghcjs-8.4.0.1.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: haskell.compiler.ghcjs84

Partial log (click to expand)

[ 57 of 221] Compiling Distribution.Types.ForeignLibOption ( Distribution/Types/ForeignLibOption.hs, dist/build/Distribution/Types/ForeignLibOption.js_p_o )
[ 58 of 221] Compiling Distribution.Types.ExecutableScope ( Distribution/Types/ExecutableScope.hs, dist/build/Distribution/Types/ExecutableScope.js_p_o )
[ 59 of 221] Compiling Distribution.Types.ComponentId ( Distribution/Types/ComponentId.hs, dist/build/Distribution/Types/ComponentId.js_p_o )
[ 60 of 221] Compiling Distribution.Types.BuildType ( Distribution/Types/BuildType.hs, dist/build/Distribution/Types/BuildType.js_p_o )
[ 61 of 221] Compiling Distribution.Types.AbiHash ( Distribution/Types/AbiHash.hs, dist/build/Distribution/Types/AbiHash.js_p_o )
[ 62 of 221] Compiling Distribution.System ( Distribution/System.hs, dist/build/Distribution/System.js_p_o )
[ 63 of 221] Compiling Distribution.SPDX.LicenseReference ( Distribution/SPDX/LicenseReference.hs, dist/build/Distribution/SPDX/LicenseReference.js_p_o )
[ 64 of 221] Compiling Distribution.SPDX.LicenseId ( Distribution/SPDX/LicenseId.hs, dist/build/Distribution/SPDX/LicenseId.js_p_o )
building of '/nix/store/wgydqympxyq6v2w45hdrzg2ry7jvd58m-ghcjs-8.4.0.1.drv' timed out after 1800 seconds
error: build of '/nix/store/wgydqympxyq6v2w45hdrzg2ry7jvd58m-ghcjs-8.4.0.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskell.compiler.ghcjs84

Partial log (click to expand)

/nix/store/qgkasjxar9gmq1da4v7nxh0qsnlp7904-ghcjs-8.4.0.1/lib/ghcjs-8.4.0.1/ghcjs-node/node_modules/esprima/bin/esparse.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2wm0059s37nmyqb0qxlsdmcj0d4hlf2a-nodejs-8.12.0/bin/node"
/nix/store/qgkasjxar9gmq1da4v7nxh0qsnlp7904-ghcjs-8.4.0.1/lib/ghcjs-8.4.0.1/ghcjs-node/node_modules/esprima/bin/esvalidate.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2wm0059s37nmyqb0qxlsdmcj0d4hlf2a-nodejs-8.12.0/bin/node"
/nix/store/qgkasjxar9gmq1da4v7nxh0qsnlp7904-ghcjs-8.4.0.1/lib/ghcjs-8.4.0.1/ghcjs-node/node_modules/har-validator/bin/har-validator: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2wm0059s37nmyqb0qxlsdmcj0d4hlf2a-nodejs-8.12.0/bin/node"
/nix/store/qgkasjxar9gmq1da4v7nxh0qsnlp7904-ghcjs-8.4.0.1/lib/ghcjs-8.4.0.1/ghcjs-node/node_modules/source-map/test/run-tests.js: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2wm0059s37nmyqb0qxlsdmcj0d4hlf2a-nodejs-8.12.0/bin/node"
/nix/store/qgkasjxar9gmq1da4v7nxh0qsnlp7904-ghcjs-8.4.0.1/lib/ghcjs-8.4.0.1/ghcjs-node/node_modules/sshpk/bin/sshpk-conv: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2wm0059s37nmyqb0qxlsdmcj0d4hlf2a-nodejs-8.12.0/bin/node"
/nix/store/qgkasjxar9gmq1da4v7nxh0qsnlp7904-ghcjs-8.4.0.1/lib/ghcjs-8.4.0.1/ghcjs-node/node_modules/sshpk/bin/sshpk-sign: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2wm0059s37nmyqb0qxlsdmcj0d4hlf2a-nodejs-8.12.0/bin/node"
/nix/store/qgkasjxar9gmq1da4v7nxh0qsnlp7904-ghcjs-8.4.0.1/lib/ghcjs-8.4.0.1/ghcjs-node/node_modules/sshpk/bin/sshpk-verify: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2wm0059s37nmyqb0qxlsdmcj0d4hlf2a-nodejs-8.12.0/bin/node"
/nix/store/qgkasjxar9gmq1da4v7nxh0qsnlp7904-ghcjs-8.4.0.1/lib/ghcjs-8.4.0.1/ghcjs-node/node_modules/uuid/bin/uuid: interpreter directive changed from "/usr/bin/env node" to "/nix/store/2wm0059s37nmyqb0qxlsdmcj0d4hlf2a-nodejs-8.12.0/bin/node"
/nix/store/qgkasjxar9gmq1da4v7nxh0qsnlp7904-ghcjs-8.4.0.1/lib/ghcjs-8.4.0.1/run.sh: interpreter directive changed from "/bin/sh" to "/nix/store/ixr5kls084hdlrs1wcy4c1q9fyw3rxfb-bash-4.4-p23/bin/sh"
/nix/store/qgkasjxar9gmq1da4v7nxh0qsnlp7904-ghcjs-8.4.0.1

@basvandijk basvandijk merged commit d429dc3 into NixOS:master Nov 22, 2018
@basvandijk
Copy link
Member

@ElvishJerricco thank you! Care to also backport this to release-18.09?

@ElvishJerricco
Copy link
Contributor Author

@basvandijk #50880 :)

basvandijk added a commit that referenced this pull request Nov 23, 2018
@basvandijk
Merge pull request #50880 from ElvishJerricco/18.09-bump-ghcjs-2018-1…
a85aacc 
…1-21

Backport #50879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm Awaiting requested review from ryantm

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ElvishJerricco @basvandijk @GrahamcOfBorg