-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Comparing changes
Open a pull request
base repository: NixOS/nixpkgs
base: 284eca792fdd
head repository: NixOS/nixpkgs
compare: d492f53faf4b
- 11 commits
- 26 files changed
- 1 contributor
Commits on Nov 19, 2018
-
ninja: make setup-hook.sh closer to setup.sh
Things changed in the Ninja setup-hook: - Respect installFlags - Automatically add checkPhase (can be disabled with dontUseNinjaCheck in the same way as dontUseNinjaBuild and dontUseNinjaInstall). Tests are only run when "ninja test" exists. - Error in build phase when build.ninja is missing. We don’t have a way to fall back to other build methods, so it’s best to be very clear when we aren’t able to build with ninja - Set -l flag to 1 when enableParallelBuilding is disabled
Configuration menu - View commit details
-
Copy full SHA for 69d1151 - Browse repository at this point
Copy the full SHA 69d1151View commit details -
treewide: remove "ninja test" checkPhase
This is now handled in the ninja setup hook. (cherry picked from commit f5e0997)
Configuration menu - View commit details
-
Copy full SHA for 955fd85 - Browse repository at this point
Copy the full SHA 955fd85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9433a38 - Browse repository at this point
Copy the full SHA 9433a38View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6f7283 - Browse repository at this point
Copy the full SHA f6f7283View commit details -
These are already in the generated makefiles!
Configuration menu - View commit details
-
Copy full SHA for 2c47a42 - Browse repository at this point
Copy the full SHA 2c47a42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ebab3d - Browse repository at this point
Copy the full SHA 4ebab3dView commit details -
ninja: don’t use build/install/check flags in setup-hook
These don’t have much use in ninja, so easiest to leave them out.
Configuration menu - View commit details
-
Copy full SHA for a16c04c - Browse repository at this point
Copy the full SHA a16c04cView commit details -
ninja: restore old -l flag value
This can be set unconditionally to $NIX_BUILD_CORES according to @orivej.
Configuration menu - View commit details
-
Copy full SHA for b75d5ad - Browse repository at this point
Copy the full SHA b75d5adView commit details -
cmake: set CTEST_OUTPUT_ON_FAILURE globally
We should always use this.
Configuration menu - View commit details
-
Copy full SHA for 285eb9a - Browse repository at this point
Copy the full SHA 285eb9aView commit details
Commits on Nov 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 70e2b0b - Browse repository at this point
Copy the full SHA 70e2b0bView commit details -
Merge pull request #50527 from matthewbauer/ninja-check-phase
Add check phase to ninja setup hook
Configuration menu - View commit details
-
Copy full SHA for d492f53 - Browse repository at this point
Copy the full SHA d492f53View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 284eca792fdd...d492f53faf4b