Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #50879 #50880

Merged
merged 1 commit into from Nov 23, 2018
Merged

Backport #50879 #50880

merged 1 commit into from Nov 23, 2018

Conversation

ElvishJerricco
Copy link
Contributor

Motivation for this change

Backporting #50879 to 18.09. This change should be considered a bugfix change, and so should be consider safe for a stable channel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 21, 2018

cc @ryantm

@ElvishJerricco ElvishJerricco mentioned this pull request Nov 22, 2018
Merged
9 tasks
@ryantm
Copy link
Member

ryantm commented Nov 22, 2018

@GrahamcOfBorg build haskell.compiler.ghcjs84

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghcjs84

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: haskell.compiler.ghcjs84

Partial log (click to expand)

[114 of 221] Compiling Distribution.Types.LegacyExeDependency ( Distribution/Types/LegacyExeDependency.hs, dist/build/Distribution/Types/LegacyExeDependency.js_p_o )
[115 of 221] Compiling Distribution.Types.BuildInfo ( Distribution/Types/BuildInfo.hs, dist/build/Distribution/Types/BuildInfo.js_p_o )
[116 of 221] Compiling Distribution.Types.HookedBuildInfo ( Distribution/Types/HookedBuildInfo.hs, dist/build/Distribution/Types/HookedBuildInfo.js_p_o )
[117 of 221] Compiling Distribution.Types.BuildInfo.Lens ( Distribution/Types/BuildInfo/Lens.hs, dist/build/Distribution/Types/BuildInfo/Lens.js_p_o )
[118 of 221] Compiling Distribution.Types.TestSuite ( Distribution/Types/TestSuite.hs, dist/build/Distribution/Types/TestSuite.js_p_o )
[119 of 221] Compiling Distribution.Types.TestSuite.Lens ( Distribution/Types/TestSuite/Lens.hs, dist/build/Distribution/Types/TestSuite/Lens.js_p_o )
[120 of 221] Compiling Distribution.Types.Library ( Distribution/Types/Library.hs, dist/build/Distribution/Types/Library.js_p_o )
[121 of 221] Compiling Distribution.Types.Library.Lens ( Distribution/Types/Library/Lens.hs, dist/build/Distribution/Types/Library/Lens.js_p_o )
building of '/nix/store/lv6s0lkh4zw1r89psz00zrqa0a3956zq-ghcjs-8.4.0.1.drv' timed out after 1800 seconds
error: build of '/nix/store/lv6s0lkh4zw1r89psz00zrqa0a3956zq-ghcjs-8.4.0.1.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: haskell.compiler.ghcjs84

Partial log (click to expand)

                                 ^
   |
39 |     return stable_ptr_table[(StgWord)sp].addr;
   |                             ^
[324 of 515] Compiling CoreOpt          ( compiler/coreSyn/CoreOpt.hs, dist/build/CoreOpt.p_o )
building of '/nix/store/1xyd6kddkra86mgq18aq6lqlfxq74r04-ghc-api-ghcjs-8.4.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/z3jix4v11aligclm96yyqa9mj8amkfnp-haddock-api-ghcjs-2.20.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9z8hzg31cafxczl9z8109m3vwq9vva1f-ghcjs-8.4.0.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/kvkmsan09zvdyfbianp2pqwyllqfxv77-ghcjs-8.4.0.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/kvkmsan09zvdyfbianp2pqwyllqfxv77-ghcjs-8.4.0.1.drv' failed

@basvandijk
Copy link
Member

Let's try one more time:

@GrahamcOfBorg build haskell.compiler.ghcjs84

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskell.compiler.ghcjs84

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: haskell.compiler.ghcjs84

Partial log (click to expand)

[ 80 of 221] Compiling Distribution.Types.BenchmarkType ( Distribution/Types/BenchmarkType.hs, dist/build/Distribution/Types/BenchmarkType.js_p_o )
[ 81 of 221] Compiling Distribution.Types.BenchmarkInterface ( Distribution/Types/BenchmarkInterface.hs, dist/build/Distribution/Types/BenchmarkInterface.js_p_o )
[ 82 of 221] Compiling Distribution.Parsec.ParseResult ( Distribution/Parsec/ParseResult.hs, dist/build/Distribution/Parsec/ParseResult.js_p_o )
[ 83 of 221] Compiling Distribution.License ( Distribution/License.hs, dist/build/Distribution/License.js_p_o )
[ 84 of 221] Compiling Language.Haskell.Extension ( Language/Haskell/Extension.hs, dist/build/Language/Haskell/Extension.js_p_o )
[ 85 of 221] Compiling Distribution.Compiler ( Distribution/Compiler.hs, dist/build/Distribution/Compiler.js_p_o )
[ 86 of 221] Compiling Distribution.Parsec.Newtypes ( Distribution/Parsec/Newtypes.hs, dist/build/Distribution/Parsec/Newtypes.js_p_o )
[ 87 of 221] Compiling Distribution.ParseUtils ( Distribution/ParseUtils.hs, dist/build/Distribution/ParseUtils.js_p_o )
building of '/nix/store/lv6s0lkh4zw1r89psz00zrqa0a3956zq-ghcjs-8.4.0.1.drv' timed out after 1800 seconds
error: build of '/nix/store/lv6s0lkh4zw1r89psz00zrqa0a3956zq-ghcjs-8.4.0.1.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: haskell.compiler.ghcjs84

Partial log (click to expand)

                                 ^
   |
39 |     return stable_ptr_table[(StgWord)sp].addr;
   |                             ^
[326 of 515] Compiling CoreUnfold       ( compiler/coreSyn/CoreUnfold.hs, dist/build/CoreUnfold.p_o )
building of '/nix/store/1xyd6kddkra86mgq18aq6lqlfxq74r04-ghc-api-ghcjs-8.4.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/z3jix4v11aligclm96yyqa9mj8amkfnp-haddock-api-ghcjs-2.20.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9z8hzg31cafxczl9z8109m3vwq9vva1f-ghcjs-8.4.0.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/kvkmsan09zvdyfbianp2pqwyllqfxv77-ghcjs-8.4.0.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/kvkmsan09zvdyfbianp2pqwyllqfxv77-ghcjs-8.4.0.1.drv' failed

@basvandijk
Copy link
Member

Unfortunately ofborg is timing out. I'm going to trust you build this successfully. It's good to merge this since GHCJS-8.4 is currently generating faulty code for us and this upgrade fixes that.

@basvandijk basvandijk merged commit a85aacc into NixOS:release-18.09 Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ElvishJerricco @Mic92 @ryantm @GrahamcOfBorg @basvandijk