Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amass: 2.8.3 -> 2.8.5 #50859

Merged
merged 1 commit into from Dec 5, 2018
Merged

amass: 2.8.3 -> 2.8.5 #50859

merged 1 commit into from Dec 5, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Nov 20, 2018 •
edited

Motivation for this change

The updated Amass is shipped with the wordlists in the wordlists output. See #50490 (review) and owasp-amass/amass#56 for the context of this update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b please review this change providing the wordlists output. Please do not merge it, Amass is not ready on the develop branch and I intend to update this PR once 2.8.4 has been released.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 20, 2018

👍 okay.
Yes I agree we should wait for a "proper" release upstream. Especially since it's really reactive :)

@c0bw3b c0bw3b self-assigned this Nov 20, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: amass

Partial log (click to expand)

strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w3vg5ksm6q1v8y9dr5l5p621qbj2jlrh-amass-unstable-2018-11-20-bin/bin
patching script interpreter paths in /nix/store/w3vg5ksm6q1v8y9dr5l5p621qbj2jlrh-amass-unstable-2018-11-20-bin
checking for references to /build in /nix/store/w3vg5ksm6q1v8y9dr5l5p621qbj2jlrh-amass-unstable-2018-11-20-bin...
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
shrinking RPATHs of ELF executables and libraries in /nix/store/s4x39a3cjwh83wqa3limqvrh070wp58r-amass-unstable-2018-11-20-wordlists
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/s4x39a3cjwh83wqa3limqvrh070wp58r-amass-unstable-2018-11-20-wordlists
checking for references to /build in /nix/store/s4x39a3cjwh83wqa3limqvrh070wp58r-amass-unstable-2018-11-20-wordlists...
/nix/store/w3vg5ksm6q1v8y9dr5l5p621qbj2jlrh-amass-unstable-2018-11-20-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: amass

Partial log (click to expand)

strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d6rv2vbaw8zqnffm5mldzwyzf1k72h7l-amass-unstable-2018-11-20-bin/bin
patching script interpreter paths in /nix/store/d6rv2vbaw8zqnffm5mldzwyzf1k72h7l-amass-unstable-2018-11-20-bin
checking for references to /build in /nix/store/d6rv2vbaw8zqnffm5mldzwyzf1k72h7l-amass-unstable-2018-11-20-bin...
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
shrinking RPATHs of ELF executables and libraries in /nix/store/zy1q24xwjrd71simmc68gc4501iyx622-amass-unstable-2018-11-20-wordlists
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/zy1q24xwjrd71simmc68gc4501iyx622-amass-unstable-2018-11-20-wordlists
checking for references to /build in /nix/store/zy1q24xwjrd71simmc68gc4501iyx622-amass-unstable-2018-11-20-wordlists...
/nix/store/d6rv2vbaw8zqnffm5mldzwyzf1k72h7l-amass-unstable-2018-11-20-bin

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

@kalbasit seems v2.8.5 was published upstream :)

@kalbasit kalbasit changed the title amass: 2.8.3 -> unstable at 2018-11-20 (do not merge) amass: 2.8.3 -> 2.8.5 Dec 5, 2018
@kalbasit kalbasit force-pushed the nixpkgs_ship-wordlist-with-amass branch from 221a959 to b9ac853 Compare December 5, 2018 03:01
@kalbasit
Copy link
Member Author

kalbasit commented Dec 5, 2018

@GrahamcOfBorg build amass

@kalbasit kalbasit merged commit e212b99 into NixOS:master Dec 5, 2018
@kalbasit kalbasit deleted the nixpkgs_ship-wordlist-with-amass branch December 5, 2018 03:15
@kalbasit
Copy link
Member Author

kalbasit commented Dec 5, 2018 •
edited

@c0bw3b sorry for the delay, I picked up 2.8.5 and tested it, works well. I updated the PR and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@c0bw3b c0bw3b

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @c0bw3b @GrahamcOfBorg