Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand nix serve manual #2554

Closed
wants to merge 2 commits into from
Closed

Expand nix serve manual #2554

wants to merge 2 commits into from

Conversation

typetetris
Copy link
Contributor

expand the manual a little bit around nix-serve, so others have an easier time setting up a binary cache with signatures and stuff.

Also removed mentions of some deprecated options in the manual as its bad style.

@typetetris
manual: add reference to NIX_SECRET_KEY_FILE for nix-serve
bba1e0a 
and mention the involved options for the client side
@typetetris
manual: replaced binary-caches with substituters
543a0cf 
- option binary-caches and extra-binary-caches are deprecated, so don't mention them
- added a reminder that only trusted users can use extra-binary-caches with
  binary caches not mentioned in nix.conf
@typetetris
Copy link
Contributor Author

Maybe that should also be merged into the 2.1 maintance branch, so it appears in the manual for 2.1.4 if there ever is such a version?

@typetetris
Copy link
Contributor Author

@edolstra : Could you take a look or request another reviewer?

@typetetris
Copy link
Contributor Author

Is there anything I can do to move that forward?
Maybe someone else can do a review?

@bhipple
Copy link
Contributor

bhipple commented Feb 16, 2019

CC @edolstra @grahamc @shlevy this PR just has documentation and looks like an improvement over the status quo, since it removes references to deprecated arguments and explains the key signing more thoroughly. Any chance it can be reviewed and merged?

@jakubgs
Copy link

jakubgs commented Feb 26, 2019

I'm currently setting up a Nix cache and these instructions helped me. It would be nice if others didn't have to look for them in PRs.

@sheyll
Copy link

sheyll commented Jul 31, 2020

This was helpful for, could this be merged?

@stale
Copy link

stale bot commented Feb 12, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Feb 12, 2021
@jakubgs
Copy link

jakubgs commented Feb 12, 2021

Why is this abandoned? This is clearly useful.

@stale stale bot removed the stale label Feb 12, 2021
@zimbatm
Copy link
Member

zimbatm commented Feb 12, 2021

Mostly because Edolstra is overloaded and focused on flakes. All the legacy commands get less attention because of that.

@stale
Copy link

stale bot commented Aug 13, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Aug 13, 2021
@jakubgs
Copy link

jakubgs commented Aug 13, 2021

No.

@stale stale bot removed the stale label Aug 13, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Apr 16, 2022
@jakubgs
Copy link

jakubgs commented Apr 16, 2022

Still no.

@stale stale bot removed the stale label Apr 16, 2022
@fricklerhandwerk
Copy link
Contributor

@typetetris sorry for the enormous time your PR was stalled. Are you still interested in adding that information? It seems there is still some interest. I can help getting it merged.

@fricklerhandwerk
Copy link
Contributor

The Nix team decided to close this PR since nix-serve is a standalone tool with its own documentation. We will remove this part from the Nix reference manual.

@typetetris
Copy link
Contributor Author

Ok with me. https://github.com/edolstra/nix-serve/blob/988014200965d96eda1285be2d2e4edd05bd3fe0/README.md already mentions NIX_SECRET_KEY_FILE. That seems sufficient.

@typetetris typetetris deleted the expand-nix-serve-manual branch February 7, 2023 09:56
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-01-20-nix-team-meeting-minutes-25/25432/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees

@fricklerhandwerk fricklerhandwerk

Labels
documentation
Projects
Nix team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@typetetris @bhipple @jakubgs @sheyll @zimbatm @fricklerhandwerk @nixos-discourse