Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia_x11: 410.78 -> 415.25 #50861

Merged
merged 1 commit into from Jan 13, 2019
Merged

nvidia_x11: 410.78 -> 415.25 #50861

merged 1 commit into from Jan 13, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Nov 20, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@eadwu
Copy link
Member Author

eadwu commented Nov 22, 2018

Seems like the 32/tls directory doesn't exist anymore? Going to have to do a bit of research for this.

@eadwu eadwu changed the title nvidia_x11: 410.78 -> 415.18 [WIP] nvidia_x11: 410.78 -> 415.18 Nov 22, 2018
@eadwu
Copy link
Member Author

eadwu commented Nov 22, 2018 •
edited

32/tls and tls don't exist anymore, and the files inside of them don't seem to be anywhere else so I think it's safe to just remove them from the commands.

Tested using nix-build -A linuxPackages_4_14.nvidia_x11 -A linuxPackages_4_18.nvidia_x11 -A linuxPackages_4_19.nvidia_x11 -A linuxPackages_4_4.nvidia_x11 -A linuxPackages_4_9.nvidia_x11.

@eadwu
Copy link
Member Author

eadwu commented Dec 1, 2018 •
edited

Patched for 4.20-rcX. Tested and built on -rc4 on my 9570. References https://devtalk.nvidia.com/default/topic/1044478/linux/is-this-patch-for-415-18-on-kernel-4-20-rcx-/.

Working fine on 4.20-rc6.

@eadwu eadwu changed the title [WIP] nvidia_x11: 410.78 -> 415.18 nvidia_x11: 410.78 -> 415.18 Dec 1, 2018
@eadwu eadwu changed the title nvidia_x11: 410.78 -> 415.18 nvidia_x11: 410.78 -> 415.22 Dec 7, 2018
@nyanloutre
Copy link
Member

nyanloutre commented Dec 8, 2018 •
edited

The 415.22 seems exciting with Vulkan transform feedback support !
I will test this in the following days.

EDIT: This PR is working for me

@eadwu eadwu changed the title nvidia_x11: 410.78 -> 415.22 nvidia_x11: 410.78 -> 415.23 Dec 12, 2018
@eadwu
Copy link
Member Author

eadwu commented Dec 12, 2018

On 415.23, no more patches are needed to finish the compilation for 4.20, though I'll keep the one for atomic64_t to suppress the errors.

@eadwu eadwu changed the title nvidia_x11: 410.78 -> 415.23 nvidia_x11: 410.78 -> 415.25 Dec 18, 2018
@eadwu
Copy link
Member Author

eadwu commented Dec 18, 2018

415.25 same as 415.23 for kernel 4.20. Haven't tested if it works during runtime, though it compiles successfully.

@eadwu eadwu mentioned this pull request Dec 27, 2018
Closed
@FRidh FRidh self-assigned this Dec 27, 2018
@mtrsk
Copy link
Member

mtrsk commented Dec 31, 2018

Tested this PR and 4.20 builds now 👍

@eadwu
Copy link
Member Author

eadwu commented Jan 4, 2019

410.93 has been released on the long-lived branch, according to #19955, it should be included in the stable release, though the 4xx series drops x86 so should it still be updated?

@romildo
Copy link
Contributor

romildo commented Jan 4, 2019

How would I test this on my unstable NixOS system?

@nyanloutre
Copy link
Member

@romildo what I do is merge this branch on a private fork of https://github.com/NixOS/nixpkgs-channels and rebuild with nixos-rebuild -I nixpkgs=path-to-fork boot, then reboot.

@romildo
Copy link
Contributor

romildo commented Jan 4, 2019

It works for me.

@vcunat
Copy link
Member

vcunat commented Jan 6, 2019

I guess here's a good place to mention: 9ee8cf5. Would someone step up to take better care of these than me? (It could be more people.) I didn't manage to give it much attention anyway.

@jethrokuan jethrokuan mentioned this pull request Jan 10, 2019
Closed
@baracoder baracoder mentioned this pull request Jan 10, 2019
Merged
10 tasks
@jethrokuan
Copy link
Contributor

Are there any blockers on this PR? It works for me as well.

@FRidh FRidh merged commit ee32fa9 into NixOS:master Jan 13, 2019
@fx-chun
Copy link
Member

fx-chun commented Jan 13, 2019

tyvm!

@eadwu eadwu deleted the nvidia_x11/415.18 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baracoder baracoder baracoder left review comments

Assignees

@FRidh FRidh

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@eadwu @nyanloutre @mtrsk @romildo @vcunat @jethrokuan @fx-chun @baracoder @FRidh @GrahamcOfBorg