Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asterisk: update all versions #50874

Closed
wants to merge 1 commit into from
Closed

Conversation

layus
Copy link
Member

@layus layus commented Nov 21, 2018

Add new Asterisk 16 branch, and update other releases.

/cc maintainers @auntie @DerTim1 @yorickvP


}:

let
common = {version, sha256, externals}: stdenv.mkDerivation rec {
inherit version;
name = "asterisk-${version}";

buildInputs = [ jansson libxml2 libxslt ncurses openssl sqlite utillinux dmidecode libuuid newt lua speex srtp wget curl iksemel ];
buildInputs = [ jansson libedit libxml2 libxslt ncurses openssl sqlite utillinux dmidecode libuuid newt lua speex srtp wget curl iksemel pkgconfig ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgconfig belongs to nativeBuildInputs. It would not hurt to add line breaks in this list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utillinux is probably also a candidate for nativeBuildInputs.

@DerTim1
Copy link

DerTim1 commented Nov 22, 2018

I think PR #48709 is then superfluous.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 23, 2018

Weird to end up with asterisk-lts > asterisk-stable (at least to me)

@mmahut
Copy link
Member

mmahut commented Aug 11, 2019

Are there any updates on this pull request, please?

@DerTim1
Copy link

DerTim1 commented Aug 12, 2019

This PR can be closed. #55378 is already merged, so this here is superfluous.

@mmahut mmahut closed this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants