openiscsi: 2.0-873 -> 2.0-877 #50873

zaninime · 2018-11-21T09:57:37Z

Motivation for this change

Update a package last updated 2 years ago.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

pkgs/os-specific/linux/open-iscsi/default.nix

c0bw3b · 2018-11-21T16:55:01Z

Changelog:
https://github.com/open-iscsi/open-iscsi/blob/master/Changelog

markuskowa

Please squash your commits when you're finished.
The rest looks good.

pkgs/os-specific/linux/open-iscsi/default.nix

markuskowa · 2018-11-22T11:45:25Z

@GrahamcOfBorg build openiscsi

GrahamcOfBorg · 2018-11-22T11:45:43Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openiscsi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-11-22T11:46:14Z

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: openiscsi

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4
shrinking /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4/bin/pkgconf
shrinking /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4/lib/libpkgconf.so.3.0.0
gzipping man pages under /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4/share/man/
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4/lib  /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4/bin
patching script interpreter paths in /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4
checking for references to /build in /nix/store/vpsn7vkig05sfaavrsk1dlnw3vj9d7b8-pkgconf-1.5.4...
cannot build derivation '/nix/store/xbh0ymznp04y6wk63abi2f1cqxzzq990-open-iscsi-2.0-877.drv': 1 dependencies couldn't be built
error: build of '/nix/store/xbh0ymznp04y6wk63abi2f1cqxzzq990-open-iscsi-2.0-877.drv' failed

GrahamcOfBorg · 2018-11-22T11:48:58Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: openiscsi

Partial log (click to expand)

trying https://github.com/open-iscsi/open-iscsi/archive/refs/tags/2.0-877.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   140    0   140    0     0    595      0 --:--:-- --:--:-- --:--:--   595
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download source from any mirror
builder for '/nix/store/63c9f56j9di6nigl5kpmql90yscycjpx-source.drv' failed with exit code 1
cannot build derivation '/nix/store/k1kicj2dc70q1rw6qnnkf9vbcjiirvch-open-iscsi-2.0-877.drv': 1 dependencies couldn't be built
error: build of '/nix/store/k1kicj2dc70q1rw6qnnkf9vbcjiirvch-open-iscsi-2.0-877.drv' failed

pkgs/os-specific/linux/open-iscsi/default.nix

zaninime · 2018-11-22T12:56:28Z

So what's the state now? I lost track of the "requested changes". I squashed the commits.

markuskowa · 2018-11-22T13:02:52Z

@GrahamcOfBorg build openiscsi

GrahamcOfBorg · 2018-11-22T13:03:10Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openiscsi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-11-22T13:03:14Z

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: openiscsi

Partial log (click to expand)


trying https://github.com/open-iscsi/open-iscsi/archive/2.0.877.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   130    0   130    0     0   1340      0 --:--:-- --:--:-- --:--:--  1340
100  590k    0  590k    0     0  2095k      0 --:--:-- --:--:-- --:--:-- 2095k
unpacking source archive /build/2.0.877.tar.gz
fixed-output derivation produced path '/nix/store/3xbg7574vw2g30xx8xwwrdadr045aizk-source' with sha256 hash '0v3dsrl34pdx0yl5jsanrpgg3vw466rl8k81hkshgq3a5mq5qhf6' instead of the expected hash '0icwgcgldildb3blib850f7kll1knyxdylk2ic33rcddr60rxib2'
cannot build derivation '/nix/store/x9f5mlpkmsbgf4vr6i0ig87q8zj32s46-open-iscsi-2.0.877.drv': 1 dependencies couldn't be built
error: build of '/nix/store/x9f5mlpkmsbgf4vr6i0ig87q8zj32s46-open-iscsi-2.0.877.drv' failed

GrahamcOfBorg · 2018-11-22T13:03:38Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: openiscsi

Partial log (click to expand)


trying https://github.com/open-iscsi/open-iscsi/archive/2.0.877.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   130    0   130    0     0    550      0 --:--:-- --:--:-- --:--:--   548
100  590k    0  590k    0     0   602k      0 --:--:-- --:--:-- --:--:--  602k
unpacking source archive /build/2.0.877.tar.gz
fixed-output derivation produced path '/nix/store/3xbg7574vw2g30xx8xwwrdadr045aizk-source' with sha256 hash '0v3dsrl34pdx0yl5jsanrpgg3vw466rl8k81hkshgq3a5mq5qhf6' instead of the expected hash '0icwgcgldildb3blib850f7kll1knyxdylk2ic33rcddr60rxib2'
cannot build derivation '/nix/store/insds95494j3i6chf1ihvwan2d438487-open-iscsi-2.0.877.drv': 1 dependencies couldn't be built
error: build of '/nix/store/insds95494j3i6chf1ihvwan2d438487-open-iscsi-2.0.877.drv' failed

markuskowa · 2018-11-22T13:13:05Z

@zaninime The changes looks good now. I just seems that the hash of the source is wrong.

zaninime · 2018-11-22T15:43:42Z

Unfortunately 0ec3a81158ef32da0a2866f8e2cc2ab02f2e3662 is the first commit that builds and works fine, and it's just a couple of commits after 2.0-877, which are all build-system related. I subscribed to the repo, so I will get updates when they tag another release. I think it's still worth to merge this and have the updated package.

markuskowa · 2018-11-22T16:02:06Z

@GrahamcOfBorg build openiscsi

GrahamcOfBorg · 2018-11-22T16:02:36Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openiscsi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-11-22T16:03:13Z

Failure on aarch64-linux (full log)

Attempted: openiscsi

Partial log (click to expand)

/build/source/usr/iscsid.c:355: undefined reference to `sd_notifyf'
iscsid.o: In function `set_state_to_ready':
/build/source/usr/iscsid.c:347: undefined reference to `sd_notify'
/build/source/usr/iscsid.c:343: undefined reference to `sd_notify'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:68: iscsid] Error 1
make[1]: Leaving directory '/build/source/usr'
make: *** [Makefile:53: user] Error 2
builder for '/nix/store/fhj9cy6a2g63l6qs1z3ra0il4g1in9br-open-iscsi-2.0.877.drv' failed with exit code 2
error: build of '/nix/store/fhj9cy6a2g63l6qs1z3ra0il4g1in9br-open-iscsi-2.0.877.drv' failed

GrahamcOfBorg · 2018-11-22T16:04:16Z

Failure on x86_64-linux (full log)

Attempted: openiscsi

Partial log (click to expand)

/build/source/usr/iscsid.c:355: undefined reference to `sd_notifyf'
iscsid.o: In function `set_state_to_ready':
/build/source/usr/iscsid.c:347: undefined reference to `sd_notify'
/build/source/usr/iscsid.c:343: undefined reference to `sd_notify'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:68: iscsid] Error 1
make[1]: Leaving directory '/build/source/usr'
make: *** [Makefile:53: user] Error 2
builder for '/nix/store/f9r3visgnn98n87i84bdns8rmc6zfyn0-open-iscsi-2.0.877.drv' failed with exit code 2
error: build of '/nix/store/f9r3visgnn98n87i84bdns8rmc6zfyn0-open-iscsi-2.0.877.drv' failed

pkgs/os-specific/linux/open-iscsi/default.nix

markuskowa · 2018-11-23T15:24:05Z

@zaninime I tried to build the package locally. Both versions, the latest release and the latest commit, failed because of unresolved symbols originating from libsystemd. Adding -lsystemd to the NIX_LDFLAGS fixes the problem for both versions. With the changes mentioned above we would be ready to merge it.

zaninime · 2018-11-24T11:26:33Z

Fixed. Sorry for the long delay.

Mic92 · 2018-11-24T11:36:12Z

@GrahamcOfBorg build openiscsi

GrahamcOfBorg · 2018-11-24T11:36:38Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openiscsi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-11-24T11:37:25Z

Success on x86_64-linux (full log)

Attempted: openiscsi

Partial log (click to expand)

strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ch6cvnvk80bqhnf08fp5yjd3g16xbirv-open-iscsi-2.0.877/lib  /nix/store/ch6cvnvk80bqhnf08fp5yjd3g16xbirv-open-iscsi-2.0.877/sbin
patching script interpreter paths in /nix/store/ch6cvnvk80bqhnf08fp5yjd3g16xbirv-open-iscsi-2.0.877
/nix/store/ch6cvnvk80bqhnf08fp5yjd3g16xbirv-open-iscsi-2.0.877/sbin/iscsi_offload: interpreter directive changed from "/bin/bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
/nix/store/ch6cvnvk80bqhnf08fp5yjd3g16xbirv-open-iscsi-2.0.877/sbin/iscsi_discovery: interpreter directive changed from "/bin/bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
/nix/store/ch6cvnvk80bqhnf08fp5yjd3g16xbirv-open-iscsi-2.0.877/sbin/iscsi-gen-initiatorname: interpreter directive changed from "/bin/bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
/nix/store/ch6cvnvk80bqhnf08fp5yjd3g16xbirv-open-iscsi-2.0.877/sbin/iscsi_fw_login: interpreter directive changed from "/bin/bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/ch6cvnvk80bqhnf08fp5yjd3g16xbirv-open-iscsi-2.0.877...
moving /nix/store/ch6cvnvk80bqhnf08fp5yjd3g16xbirv-open-iscsi-2.0.877/sbin/* to /nix/store/ch6cvnvk80bqhnf08fp5yjd3g16xbirv-open-iscsi-2.0.877/bin
/nix/store/ch6cvnvk80bqhnf08fp5yjd3g16xbirv-open-iscsi-2.0.877

GrahamcOfBorg · 2018-11-24T11:38:21Z

Success on aarch64-linux (full log)

Attempted: openiscsi

Partial log (click to expand)

strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ni3jgzkzlwlrrx9kll9h7z7xbr20m6sc-open-iscsi-2.0.877/lib  /nix/store/ni3jgzkzlwlrrx9kll9h7z7xbr20m6sc-open-iscsi-2.0.877/sbin
patching script interpreter paths in /nix/store/ni3jgzkzlwlrrx9kll9h7z7xbr20m6sc-open-iscsi-2.0.877
/nix/store/ni3jgzkzlwlrrx9kll9h7z7xbr20m6sc-open-iscsi-2.0.877/sbin/iscsi-gen-initiatorname: interpreter directive changed from "/bin/bash" to "/nix/store/n1kfdl37qpzh3xn6klbym1ay6xpxvmw1-bash-4.4-p23/bin/bash"
/nix/store/ni3jgzkzlwlrrx9kll9h7z7xbr20m6sc-open-iscsi-2.0.877/sbin/iscsi_offload: interpreter directive changed from "/bin/bash" to "/nix/store/n1kfdl37qpzh3xn6klbym1ay6xpxvmw1-bash-4.4-p23/bin/bash"
/nix/store/ni3jgzkzlwlrrx9kll9h7z7xbr20m6sc-open-iscsi-2.0.877/sbin/iscsi_fw_login: interpreter directive changed from "/bin/bash" to "/nix/store/n1kfdl37qpzh3xn6klbym1ay6xpxvmw1-bash-4.4-p23/bin/bash"
/nix/store/ni3jgzkzlwlrrx9kll9h7z7xbr20m6sc-open-iscsi-2.0.877/sbin/iscsi_discovery: interpreter directive changed from "/bin/bash" to "/nix/store/n1kfdl37qpzh3xn6klbym1ay6xpxvmw1-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/ni3jgzkzlwlrrx9kll9h7z7xbr20m6sc-open-iscsi-2.0.877...
moving /nix/store/ni3jgzkzlwlrrx9kll9h7z7xbr20m6sc-open-iscsi-2.0.877/sbin/* to /nix/store/ni3jgzkzlwlrrx9kll9h7z7xbr20m6sc-open-iscsi-2.0.877/bin
/nix/store/ni3jgzkzlwlrrx9kll9h7z7xbr20m6sc-open-iscsi-2.0.877

markuskowa · 2018-11-24T12:13:27Z

Thanks for cleaning up the derivation!

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Nov 21, 2018

markuskowa requested changes Nov 21, 2018

View reviewed changes

markuskowa requested changes Nov 22, 2018

View reviewed changes

pkgs/os-specific/linux/open-iscsi/default.nix Outdated Show resolved Hide resolved

markuskowa self-assigned this Nov 22, 2018

markuskowa reviewed Nov 22, 2018

View reviewed changes

pkgs/os-specific/linux/open-iscsi/default.nix Outdated Show resolved Hide resolved

markuskowa reviewed Nov 22, 2018

View reviewed changes

pkgs/os-specific/linux/open-iscsi/default.nix Outdated Show resolved Hide resolved

c0bw3b requested changes Nov 22, 2018

View reviewed changes

pkgs/os-specific/linux/open-iscsi/default.nix Outdated Show resolved Hide resolved

pkgs/os-specific/linux/open-iscsi/default.nix Outdated Show resolved Hide resolved

zaninime force-pushed the openscsi branch from 410276c to 385fdae Compare November 22, 2018 12:49

markuskowa requested changes Nov 22, 2018

View reviewed changes

pkgs/os-specific/linux/open-iscsi/default.nix Outdated Show resolved Hide resolved

zaninime force-pushed the openscsi branch from 385fdae to a8a79c3 Compare November 22, 2018 15:41

markuskowa requested changes Nov 22, 2018

View reviewed changes

pkgs/os-specific/linux/open-iscsi/default.nix Outdated Show resolved Hide resolved

pkgs/os-specific/linux/open-iscsi/default.nix Outdated Show resolved Hide resolved

zaninime force-pushed the openscsi branch from a8a79c3 to a686002 Compare November 24, 2018 11:18

openiscsi: 2.0-873 -> 2.0-877

6ce3525

zaninime force-pushed the openscsi branch from a686002 to 6ce3525 Compare November 24, 2018 11:25

c0bw3b approved these changes Nov 24, 2018

View reviewed changes

markuskowa approved these changes Nov 24, 2018

View reviewed changes

markuskowa merged commit 651baa7 into NixOS:master Nov 24, 2018

zaninime deleted the openscsi branch March 31, 2019 21:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openiscsi: 2.0-873 -> 2.0-877 #50873

openiscsi: 2.0-873 -> 2.0-877 #50873

zaninime commented Nov 21, 2018

c0bw3b commented Nov 21, 2018

markuskowa left a comment

markuskowa commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

zaninime commented Nov 22, 2018

markuskowa commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

markuskowa commented Nov 22, 2018

zaninime commented Nov 22, 2018

markuskowa commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

markuskowa commented Nov 23, 2018

zaninime commented Nov 24, 2018

Mic92 commented Nov 24, 2018

GrahamcOfBorg commented Nov 24, 2018

GrahamcOfBorg commented Nov 24, 2018

GrahamcOfBorg commented Nov 24, 2018

markuskowa commented Nov 24, 2018

openiscsi: 2.0-873 -> 2.0-877 #50873

openiscsi: 2.0-873 -> 2.0-877 #50873

Conversation

zaninime commented Nov 21, 2018

Motivation for this change

Things done

c0bw3b commented Nov 21, 2018

markuskowa left a comment

Choose a reason for hiding this comment

markuskowa commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

zaninime commented Nov 22, 2018

markuskowa commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

markuskowa commented Nov 22, 2018

zaninime commented Nov 22, 2018

markuskowa commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

GrahamcOfBorg commented Nov 22, 2018

markuskowa commented Nov 23, 2018

zaninime commented Nov 24, 2018

Mic92 commented Nov 24, 2018

GrahamcOfBorg commented Nov 24, 2018

GrahamcOfBorg commented Nov 24, 2018

GrahamcOfBorg commented Nov 24, 2018

markuskowa commented Nov 24, 2018