Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-google-auth: init at 0.0.29 #50863

Merged
merged 1 commit into from Dec 1, 2018
Merged

aws-google-auth: init at 0.0.29 #50863

merged 1 commit into from Dec 1, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 20, 2018

Motivation for this change

Closes #50840

cc: @coretemp

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner November 20, 2018 23:38
coretemp
coretemp approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@coretemp coretemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

The only thing I can think of is to (open/link to) an upstream issue for the test files.

@coretemp
Copy link
Contributor

Would also be nice to have it in 18.09 for whoever is merging this.

@worldofpeace
Copy link
Contributor

@marsam I pushed various nitpicks that I found necessary.
Let me know what you think.

@marsam
Copy link
Contributor Author

marsam commented Nov 29, 2018

@worldofpeace sorry for the delay; looks a lot better, thanks!

@worldofpeace
Copy link
Contributor

Just going to test that it builds here now,
I've already tested execution locally and it seemed fine (can't test the function though).

@GrahamcOfBorg build aws-google-auth

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aws-google-auth

Partial log (click to expand)

test_get_password_when_tty (aws_google_auth.tests.test_util.TestUtilMethods) ... ok
test_unicode_to_string_if_needed (aws_google_auth.tests.test_util.TestUtilMethods) ... ok
test_unicode_to_string_if_needed_python_2 (aws_google_auth.tests.test_util.TestUtilMethods) ... ok
test_unicode_to_string_if_needed_python_3 (aws_google_auth.tests.test_util.TestUtilMethods) ... ok

----------------------------------------------------------------------
Ran 96 tests in 1.254s

OK
/nix/store/63l2xb3m4mxspm4fs1r58697cq5md1gn-aws-google-auth-0.0.29

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aws-google-auth

Partial log (click to expand)

test_get_password_when_tty (aws_google_auth.tests.test_util.TestUtilMethods) ... ok
test_unicode_to_string_if_needed (aws_google_auth.tests.test_util.TestUtilMethods) ... ok
test_unicode_to_string_if_needed_python_2 (aws_google_auth.tests.test_util.TestUtilMethods) ... ok
test_unicode_to_string_if_needed_python_3 (aws_google_auth.tests.test_util.TestUtilMethods) ... ok

----------------------------------------------------------------------
Ran 96 tests in 1.587s

OK
/nix/store/z6ghavpiayrxa70y861rdwmfm955q9xx-aws-google-auth-0.0.29

@worldofpeace worldofpeace changed the title pythonPackages.aws-google-auth: init at 0.0.29 aws-google-auth: init at 0.0.29 Nov 29, 2018
@worldofpeace
Copy link
Contributor

Going to cc some maintainers as this might have gotten opinionated by my changes.

cc @dotlambda @Ma27

Ma27
Ma27 approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except my (minor) comment the patch seems fine 👍

@marsam
Copy link
Contributor Author

marsam commented Dec 1, 2018

@worldofpeace I've added myself as maintainer and added a link to the upstream issue

@worldofpeace
Copy link
Contributor

@worldofpeace I've added myself as maintainer and added a link to the upstream issue

@marsam Excellent 👍
I've also squashed and corrected the commit msg.

@worldofpeace worldofpeace merged commit 50bb0af into NixOS:master Dec 1, 2018
@worldofpeace
Copy link
Contributor

Thanks ✨

@marsam marsam deleted the feature/add-aws-google-auth branch December 1, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@Ma27 Ma27 Ma27 approved these changes

@coretemp coretemp coretemp approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @coretemp @worldofpeace @GrahamcOfBorg @Ma27