Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pijul: 0.10.0 -> 0.11.0 #50870

Merged
merged 2 commits into from Nov 22, 2018
Merged

pijul: 0.10.0 -> 0.11.0 #50870

merged 2 commits into from Nov 22, 2018

Conversation

RohanHart
Copy link
Contributor

Motivation for this change

update to latest

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dywedir
Copy link
Member

dywedir commented Nov 21, 2018

@GrahamcOfBorg build pijul

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pijul

Partial log (click to expand)

   Compiling hyper-tls v0.3.1
   Compiling reqwest v0.9.3
   Compiling pijul v0.11.0 (/private/tmp/nix-build-pijul-0.11.0.drv-0/pijul-0.11.0/pijul)
    Finished release [optimized] target(s) in 6m 58s
installing
post-installation fixup
strip is /nix/store/rk3p99jbj4idl3dkkg1rxja5gz0qgs98-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2lzgccjli7cxa53n3x9m35q69chfl0nn-pijul-0.11.0/bin
patching script interpreter paths in /nix/store/2lzgccjli7cxa53n3x9m35q69chfl0nn-pijul-0.11.0
/nix/store/2lzgccjli7cxa53n3x9m35q69chfl0nn-pijul-0.11.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pijul

Partial log (click to expand)

    Finished release [optimized] target(s) in 5m 08s
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2ck17yx9fy7xddr0zis6il2i26hzspw7-pijul-0.11.0
shrinking /nix/store/2ck17yx9fy7xddr0zis6il2i26hzspw7-pijul-0.11.0/bin/pijul
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2ck17yx9fy7xddr0zis6il2i26hzspw7-pijul-0.11.0/bin
patching script interpreter paths in /nix/store/2ck17yx9fy7xddr0zis6il2i26hzspw7-pijul-0.11.0
checking for references to /build in /nix/store/2ck17yx9fy7xddr0zis6il2i26hzspw7-pijul-0.11.0...
/nix/store/2ck17yx9fy7xddr0zis6il2i26hzspw7-pijul-0.11.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pijul

Partial log (click to expand)

    Finished release [optimized] target(s) in 6m 11s
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5dxqykzz10pa2bd4fcl2la5hlq5s9aqz-pijul-0.11.0
shrinking /nix/store/5dxqykzz10pa2bd4fcl2la5hlq5s9aqz-pijul-0.11.0/bin/pijul
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5dxqykzz10pa2bd4fcl2la5hlq5s9aqz-pijul-0.11.0/bin
patching script interpreter paths in /nix/store/5dxqykzz10pa2bd4fcl2la5hlq5s9aqz-pijul-0.11.0
checking for references to /build in /nix/store/5dxqykzz10pa2bd4fcl2la5hlq5s9aqz-pijul-0.11.0...
/nix/store/5dxqykzz10pa2bd4fcl2la5hlq5s9aqz-pijul-0.11.0

dywedir
dywedir approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@dywedir dywedir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@worldofpeace worldofpeace mentioned this pull request Nov 22, 2018
Closed
9 tasks
@vbgl vbgl merged commit 25e7f59 into NixOS:master Nov 22, 2018
@P-E-Meunier
Copy link
Contributor

Great, but why not use Carnix instead? I wrote it especially for this.

@RohanHart
Copy link
Contributor Author

Great, but why not use Carnix instead? I wrote it especially for this.

It was the path of least resistance.

@Mic92
Copy link
Member

Mic92 commented Dec 10, 2018

The generated expression was too large. This could be fixed by #50923 (comment) but I it still not clear to me, how it is supposed to be used.

grwlf pushed a commit to grwlf/nixpkgs that referenced this pull request Jan 28, 2019
@RohanHart @grwlf
pijul: 0.10.0 -> 0.11.0 (NixOS#50870)
8046ca3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@dywedir dywedir dywedir approved these changes

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@RohanHart @dywedir @GrahamcOfBorg @P-E-Meunier @Mic92 @vbgl @worldofpeace @Janik-Haag