Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpra: 2.3.4 -> 2.4.2 #51877

Closed
wants to merge 1 commit into from
Closed

xpra: 2.3.4 -> 2.4.2 #51877

wants to merge 1 commit into from

Conversation

deepfire
Copy link
Contributor

Motivation for this change

XPRA is broken as of now (#41106 and #30822), here's hoping the bump fixes it.

There was another curious artifact in 2.3.4, by the way -- the features file had this:

$ ag LOCAL_SERVERS_SUPPORTED /nix/store/kfrnj33702mfa8y8629adh894ccn731z-xpra-2.3.4/lib/python3.6/site-packages/xpra/
/nix/store/kfrnj33702mfa8y8629adh894ccn731z-xpra-2.3.4/lib/python3.6/site-packages/xpra/platform/features.py
14:LOCAL_SERVERS_SUPPORTED = PYTHON2

..which resulted in xpra having no start subcommand.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@deepfire
Copy link
Contributor Author

cc @bgamari

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 11, 2018

Previous "unbreaking" attempts and/or related : #48872 and #50365

@deepfire
Copy link
Contributor Author

Thank you for the context, @c0bw3b!

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@GrahamcOfBorg build xpra

Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this unbreaks xpra, it should remove the broken=true; meta attribute. When I run nix-review pr 51877, it says

4 package are marked as broken and were skipped:
ib-controller run-scaled winswitch xpra

so there might be more broken things to contend with.

@aanderse
Copy link
Member

For any interested parties: #58151 (comment)

Results of nix-review:
1 package failed to build:
winswitch
2 package were build:
run-scaled xpra

@c0bw3b
Copy link
Contributor

c0bw3b commented May 12, 2019

Closing in favor of #58151

@c0bw3b c0bw3b closed this May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants