Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildRustCrate: fix extraRustcOpts so it is not discarded #51882

Merged
merged 1 commit into from Dec 12, 2018
Merged

buildRustCrate: fix extraRustcOpts so it is not discarded #51882

merged 1 commit into from Dec 12, 2018

Conversation

djahandarie
Copy link
Contributor

Motivation for this change

The overridable extraRustcOpts in buildRustCrate was actually discarded, so I piped it through to the right spot in the nix expression.

cc @P-E-Meunier @thoughtpolice

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thoughtpolice
Copy link
Member

@GrahamcOfBorg build carnix

@thoughtpolice thoughtpolice merged commit da84602 into NixOS:master Dec 12, 2018
@P-E-Meunier
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@djahandarie @thoughtpolice @P-E-Meunier @GrahamcOfBorg @Janik-Haag