Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #51444

Merged
merged 590 commits into from Dec 19, 2018
Merged

Staging next #51444

merged 590 commits into from Dec 19, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Dec 3, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre
Copy link
Member

There is a breakage introduced by the pyqt update (5.10 -> 5.11), the sip package must be handeled differently to be able to import the module.

I did some investigation here : #49400 (comment)

boto3: 1.9.36 -> 1.9.62
awscli: 1.16.72

I update all three of these at a time because they rely on each other
and get annoyed when such changes are non-atomic. Also added a note to
the packages telling people that this is needed. I tested awscli and the
libraries against a real account.
dotlambda referenced this pull request Dec 12, 2018
It currently breaks on Python 3.7 due to `async` becoming a reserved keyword
@Mic92 Mic92 mentioned this pull request Dec 12, 2018
13 tasks
@grahamc
Copy link
Member

grahamc commented Dec 14, 2018

I'm noticing the staging jobset on hydra hasn't run since November 27 ,and it hasn't even finished. Is there a jobset I don't know about? I'm concerned maybe something has broken in the shuffle here.

@grahamc
Copy link
Member

grahamc commented Dec 14, 2018

@copumpkin
Copy link
Member

@FRidh is this merge likely to happen soon? I'm waiting for the awscli/boto3/botocore updates and might manually transplant them over to master if this branch is going to take a while. There's no fundamental reason I think to bundle those with the rest of these updates, right?

@FRidh
Copy link
Member Author

FRidh commented Dec 18, 2018

Just merged master into staging-next again.

@FRidh FRidh merged commit 1a51abe into master Dec 19, 2018
@FRidh
Copy link
Member Author

FRidh commented Dec 19, 2018

Seems like there were more recent changes that had not been rebuild as we have a mass-rebuild on master now.

@hedning
Copy link
Contributor

hedning commented Dec 19, 2018

Looks like it comes from here: #51960, probably targeted at master by a mistake.

@timokau timokau mentioned this pull request Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet