New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kube-router: init at 0.2.3 #51445
kube-router: init at 0.2.3 #51445
Conversation
|
@worldofpeace Valid point! Thanks. I injected the metadata needed through Go ldflags (1c263175f2df893e7efbe02e1b1c639216855502). Kube-router apparently intents the |
@GrahamcOfBorg build kube-router |
c42107c
to
1c26317
Compare
I'm good with |
Guess if I just remove the "OS" part, it would be :) |
1c26317
to
cd42cc2
Compare
Wow.. I failed that squash.. Sorry. Let me fix it. |
cd42cc2
to
07585de
Compare
Ok.. My branch is fixed now, @GrahamcOfBorg build kube-router |
@GrahamcOfBorg build kube-router |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built and executed successfully 👍
Can't verify the function though, but it's probably fine.
Sorry, didn't mean to end up on the list of reviewers. |
@worldofpeace want me to squash before merging? |
@johanot I actually was going to do that for you when I merged it, but I can't test this properly. Have you been able to? |
Great thanks! You mean test kube-router itself? We've used kube-router in production for half a year now on our NixOS kubernetes cluster. Just been too busy to upstream the package. :) I believe @colemickens can tell a similar story. As a separate PR some day, we might upstream our kube-router module for which we have a corresponding NixOS test as well. |
1 similar comment
Great thanks! You mean test kube-router itself? We've used kube-router in production for half a year now on our NixOS kubernetes cluster. Just been too busy to upstream the package. :) I believe @colemickens can tell a similar story. As a separate PR some day, we might upstream our kube-router module for which we have a corresponding NixOS test as well. |
ac429c2
to
af04756
Compare
Excellent, I hope to see that eventually. Merging. |
@johanot Thanks for getting this piece in here |
Motivation for this change
Kube-router is a good alternative to flannel and weavenet as a self-contained kubernetes software defined network solution. It's written in Golang and utilizes iptables, ipvs and ip utilities directly.
Learn more at: https://github.com/cloudnativelabs/kube-router and https://www.kube-router.io/
As pre-agreed, I've added @colemickens as co-maintainer on this package.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)