Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-router: init at 0.2.3 #51445

Merged
merged 1 commit into from Dec 6, 2018
Merged

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Dec 3, 2018

Motivation for this change

Kube-router is a good alternative to flannel and weavenet as a self-contained kubernetes software defined network solution. It's written in Golang and utilizes iptables, ipvs and ip utilities directly.
Learn more at: https://github.com/cloudnativelabs/kube-router and https://www.kube-router.io/

As pre-agreed, I've added @colemickens as co-maintainer on this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

kube-router --version doesn't report a version.

Running ./result-bin/bin/kube-router version , built on , go1.11.2

@johanot
Copy link
Contributor Author

johanot commented Dec 5, 2018

@worldofpeace Valid point! Thanks. I injected the metadata needed through Go ldflags (1c263175f2df893e7efbe02e1b1c639216855502). Kube-router apparently intents the built on ... part to contain a date, but in the name of reproducibility I just inserted NixOS. What do you think? Prefer epoch here?

@johanot
Copy link
Contributor Author

johanot commented Dec 5, 2018

@GrahamcOfBorg build kube-router

@worldofpeace
Copy link
Contributor

Kube-router apparently intents the built on ... part to contain a date, but in the name of reproducibility I just inserted NixOS. What do you think? Prefer epoch here?

I'm good with NixOS, however that might not always be accurate.

@johanot
Copy link
Contributor Author

johanot commented Dec 5, 2018

Guess if I just remove the "OS" part, it would be :)

@johanot
Copy link
Contributor Author

johanot commented Dec 5, 2018

Wow.. I failed that squash.. Sorry. Let me fix it.

@johanot
Copy link
Contributor Author

johanot commented Dec 5, 2018

Ok.. My branch is fixed now, NixOS has been changed to just Nix, changes are squashed and random other commits have been removed again. @FRidh can be removed from "reviewers" as well. Sorry for the mess.

@GrahamcOfBorg build kube-router

@worldofpeace worldofpeace removed the request for review from FRidh December 5, 2018 23:31
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build kube-router

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and executed successfully 👍
Can't verify the function though, but it's probably fine.

@adamtulinius
Copy link
Member

Sorry, didn't mean to end up on the list of reviewers.

@johanot
Copy link
Contributor Author

johanot commented Dec 6, 2018

@worldofpeace want me to squash before merging?

@worldofpeace
Copy link
Contributor

@johanot I actually was going to do that for you when I merged it, but I can't test this properly.

Have you been able to?

@johanot
Copy link
Contributor Author

johanot commented Dec 6, 2018

Great thanks! You mean test kube-router itself? We've used kube-router in production for half a year now on our NixOS kubernetes cluster. Just been too busy to upstream the package. :) I believe @colemickens can tell a similar story.

As a separate PR some day, we might upstream our kube-router module for which we have a corresponding NixOS test as well.

1 similar comment
@johanot
Copy link
Contributor Author

johanot commented Dec 6, 2018

Great thanks! You mean test kube-router itself? We've used kube-router in production for half a year now on our NixOS kubernetes cluster. Just been too busy to upstream the package. :) I believe @colemickens can tell a similar story.

As a separate PR some day, we might upstream our kube-router module for which we have a corresponding NixOS test as well.

@worldofpeace
Copy link
Contributor

Great thanks! You mean test kube-router itself? We've used kube-router in production for half a year now on our NixOS kubernetes cluster. Just been too busy to upstream the package. :) I believe @colemickens can tell a similar story.

As a separate PR some day, we might upstream our kube-router module for which we have a corresponding NixOS test as well.

Excellent, I hope to see that eventually. Merging.

@worldofpeace worldofpeace merged commit 015b2b1 into NixOS:master Dec 6, 2018
@worldofpeace
Copy link
Contributor

@johanot Thanks for getting this piece in here

@johanot johanot deleted the kube-router-init branch December 6, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants