Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde-applications: 18.08.1 -> 18.12.0 #51449

Merged
merged 1 commit into from Dec 16, 2018
Merged

kde-applications: 18.08.1 -> 18.12.0 #51449

merged 1 commit into from Dec 16, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Dec 3, 2018 •
edited

Motivation for this change

This is a preparation of the new kde applications release. Currently this uses the beta release, I will update to the stable on the final release :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bkchr bkchr requested a review from ttuegel as a code owner December 3, 2018 13:04
@bkchr bkchr changed the title kde-applications: 18.08.1 -> 18.12.0 WIP kde-applications: 18.08.1 -> 18.12.0 Dec 14, 2018
@bkchr
Copy link
Contributor Author

bkchr commented Dec 14, 2018

@ttuegel as it is released now, this pr is ready to be merged :)

@ttuegel ttuegel merged commit 8401fe2 into NixOS:master Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkchr @ttuegel @GrahamcOfBorg