Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openblas: 0.3.3 -> 0.3.4 #51467

Merged
merged 1 commit into from Dec 7, 2018
Merged

openblas: 0.3.3 -> 0.3.4 #51467

merged 1 commit into from Dec 7, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Dec 3, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh mentioned this pull request Dec 3, 2018
Closed
@Mic92 Mic92 requested a review from markuskowa December 3, 2018 23:49
@markuskowa
Copy link
Member

Quick test of some sensitive packages:
@GrahamcOfBorg build arpack julia scalapack

@markuskowa
Copy link
Member

markuskowa commented Dec 4, 2018 •
edited

Looking at the number of rebuilds it should go into staging instead of master?
CC @ttuegel as maintainer.
Changelog: https://github.com/xianyi/OpenBLAS/releases

@markuskowa
Copy link
Member

@GrahamcOfBorg build julia_10 scalapack python36Packages.numpy

@FRidh FRidh changed the base branch from master to staging December 4, 2018 15:30
@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos labels Dec 4, 2018
markuskowa
markuskowa approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@markuskowa
Copy link
Member

@ilya-kolpakov can you confirm that openblas-0.3.4 works properly with respect to the numpy bug?

@FRidh FRidh merged commit 4deb04a into NixOS:staging Dec 7, 2018
@FRidh FRidh deleted the openblas branch December 7, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @markuskowa @GrahamcOfBorg