Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hunspell: unbreak mythes build, due transient dependencies #51454

Merged
merged 1 commit into from Dec 4, 2018
Merged

hunspell: unbreak mythes build, due transient dependencies #51454

merged 1 commit into from Dec 4, 2018

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Dec 3, 2018

Motivation for this change

Linking of this was broken
/nix/store/6s8dkfj3irwv52cap2hd9k7gaddklfs1-binutils-2.30/bin/ld: cannot find -ltinfo

(and as mythes is transient dependency of libreoffice, LO was broken as well)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 3, 2018 •
edited

Related: #51297

I'm not sure this is the proper fix. See my comment in the issue.
To be clearer: it would fix mythes but we could still see the same issue with another package depending on hunspell.

@avnik avnik changed the title mythes: fix link error on missed tinfo library (ncurses) hunspell: unbreak mythes build, due transient dependecnies Dec 3, 2018
@avnik avnik mentioned this pull request Dec 3, 2018
Closed
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 3, 2018

The related issue also suggests that enchant also expect to find libtinfo.

@c0bw3b c0bw3b changed the title hunspell: unbreak mythes build, due transient dependecnies hunspell: unbreak mythes build, due transient dependencies Dec 3, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 3, 2018

@GrahamcOfBorg build mythes

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 3, 2018

Ok now
@GrahamcOfBorg build enchant balsa

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 3, 2018

(enchant 1.6.1 failure is unrelated, it was already failing before. I was just checking)

@avnik
Copy link
Contributor Author

avnik commented Dec 3, 2018

At least locally enchant is was built ok

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 3, 2018

@GrahamcOfBorg build mythes

@c0bw3b c0bw3b merged commit 833ee18 into NixOS:master Dec 4, 2018
@c0bw3b c0bw3b mentioned this pull request Dec 4, 2018
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avnik @c0bw3b @GrahamcOfBorg