ghc: don’t add libiconv automatically #51455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
requested review from
basvandijk,
peti and
ryantm
as code owners
peti
reviewed
Dec 4, 2018
| @@ -206,6 +206,8 @@ stdenv.mkDerivation (rec { | |||
| "--disable-large-address-space" | |||
| ]; | |||
|
|
|||
| dontAddExtraLibs = true; | |||
There was a problem hiding this comment.
Could you please add a comment in front of those attributes that explains what they accomplish and/or why they are needed?
There was a problem hiding this comment.
Yes - done in latest in push.
ghc needs it to fail to correctly detect it for later.
matthewbauer
force-pushed
the
fix-46814
branch
from
3c2bb12
to
7a00e80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghc needs it to fail to correctly detect it for later. GHC uses autoconf to detect whether "-liconv" is needed. The test tries a test program that needs libiconv to work. If the test fails, libiconv is added to all LDFLAGS that GHC compiles. We want this to happen so that GHC works outside of Nix's cc-wrapper! So, this PR adds
dontAddExtraLibsthat tells cc-wrapper to not add extra libraries. I've added a short description in the docs explaining the situation as well.Fixes #46814.