Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmrconfig: 2018-11-07 -> 1.0 #51452

Merged
merged 1 commit into from Dec 3, 2018
Merged

dmrconfig: 2018-11-07 -> 1.0 #51452

merged 1 commit into from Dec 3, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Dec 3, 2018

Motivation for this change

Upstream have made a new release that builds, so switched to release versions instead of random commits.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor Author

etu commented Dec 3, 2018

@GrahamcOfBorg build dmrconfig

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 3, 2018

The version is not displayed correctly:

$ ./result/bin/dmrconfig
DMR Config, Version ., Copyright (C) 2018 Serge Vakulenko KK6ABQ

The Makefile should probably be patched to set VERSION and GITCOUNT manually and not try to use git.
It would also remove the multiple errors in the build logs

/nix/store/az8gqspcfqr3fdhkscz60qhjnxdh5ggs-bash-4.4-p23/bin/bash: git: command not found

@etu
Copy link
Contributor Author

etu commented Dec 3, 2018

@c0bw3b Replaced the usage of git and got a proper version printed:

DMR Config, Version 1.0.0, Copyright (C) 2018 Serge Vakulenko KK6ABQ

@etu
Copy link
Contributor Author

etu commented Dec 3, 2018

@GrahamcOfBorg build dmrconfig

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 3, 2018

Thanks.

@c0bw3b c0bw3b merged commit a700560 into NixOS:master Dec 3, 2018
@etu etu deleted the stable-dmrconfig branch December 3, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @c0bw3b @GrahamcOfBorg