Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka: 2.0.0 -> 2.0.1, Add 2.1 #51463

Merged
merged 3 commits into from Dec 5, 2018
Merged

Kafka: 2.0.0 -> 2.0.1, Add 2.1 #51463

merged 3 commits into from Dec 5, 2018

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Updates

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NeQuissimus
Copy link
Member Author

@GrahamcOfBorg test kafka

@NeQuissimus NeQuissimus requested a review from xeji December 3, 2018 16:58
@rasendubi
Copy link
Member

@GrahamcOfBorg build apacheKafka_2_0 apacheKafka_2_1

Mic92
Mic92 reviewed Dec 4, 2018
View reviewed changes
nixos/tests/kafka.nix
@@ -70,4 +70,6 @@ in with pkgs; {
kafka_0_11 = makeKafkaTest "kafka_0_11" apacheKafka_0_11;
kafka_1_0 = makeKafkaTest "kafka_1_0" apacheKafka_1_0;
kafka_1_1 = makeKafkaTest "kafka_1_1" apacheKafka_1_1;
kafka_2_0 = makeKafkaTest "kafka_2_0" apacheKafka_2_0;
kafka_2_1 = makeKafkaTest "kafka_2_1" apacheKafka_2_1;
Copy link
Member

@Mic92 Mic92 Dec 4, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems Kafka versions older then 0.10 should be removed: https://kafka.apache.org/downloads

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And some version also could use an upgrade.

@NeQuissimus NeQuissimus merged commit 16f42b3 into NixOS:master Dec 5, 2018
@NeQuissimus NeQuissimus deleted the kafka branch December 5, 2018 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@xeji xeji Awaiting requested review from xeji

Assignees
No one assigned
Labels
6.topic: nixos 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NeQuissimus @rasendubi @Mic92 @GrahamcOfBorg