Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-multi-user: fail only if /nix is not empty #2573

Closed
wants to merge 1 commit into from

Conversation

uvNikita
Copy link

@uvNikita uvNikita commented Dec 12, 2018

This will allow having /nix on a separate partition. Fixes #2042 and #2407.

@uvNikita
Copy link
Author

cc @grahamc

@uvNikita
Copy link
Author

@grahamc Is there anything that's blocking this PR from been merged? We are planning to put /nix on a separate partition and it would be very convenient if the upstream installer would support this case :)

@orivej
Copy link
Contributor

orivej commented Jan 29, 2019

I am replacing if [ -d /nix ] with if [ -e /nix/store -o -e /nix/var ] for the same purpose.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/does-a-debian-package-for-nix-2-exist/2265/5

This will allow having /nix on a separate partition. Fixes NixOS#2042 and NixOS#2407.
@uvNikita
Copy link
Author

@orivej I replaced implementation with your version since it seems to be more reliable, thanks for the input :)

@uvNikita
Copy link
Author

For someone who will have the same issue in the future [1], we ended up using these packages kindly provided by @Mic92 and @dezgeg: https://github.com/Mic92/nix-fpm-multiuser/releases.

@abathur
Copy link
Member

abathur commented Nov 10, 2020

This can be closed; a similar fix was merged in #3054.

@uvNikita uvNikita closed this Nov 10, 2020
@uvNikita uvNikita deleted the patch-1 branch November 10, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-user install: allow /nix to exist
4 participants