Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.12.3 -> 1.13.1 #51896

Merged
merged 1 commit into from Dec 17, 2018
Merged

kubernetes: 1.12.3 -> 1.13.1 #51896

merged 1 commit into from Dec 17, 2018

Conversation

nicknovitski
Copy link
Contributor

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" (Nox errored out :p)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Dec 12, 2018

cc @johanot

@johanot
Copy link
Contributor

johanot commented Dec 12, 2018

Thanks. Will do some testing later today.

@srhb srhb self-assigned this Dec 13, 2018
@johanot
Copy link
Contributor

johanot commented Dec 13, 2018

Using v1.13 with the nixos/kubernetes module doesn't work, which I kind of expected. I will look into the details of the required module changes soon.

@srhb
Copy link
Contributor

srhb commented Dec 13, 2018

OK, let's hold off on merging this till the module is compatible then. :)

@johanot
Copy link
Contributor

johanot commented Dec 13, 2018 •
edited

Sure. And... Let's get 1.13.1, since it was released just now! :)

@nicknovitski
Copy link
Contributor Author

@johant Would it be more helpful to you if I updated this pr to 1.13.1 and kept it open, or just closed it?

@johanot johanot mentioned this pull request Dec 16, 2018
Merged
10 tasks
@johanot
Copy link
Contributor

johanot commented Dec 16, 2018

Turns out the module itself is fine, but the test cases were failing due to an unsupported alpha feature: BoundServiceAccountTokenVolume. I can accept that the module doesn't yet support this feature, but I think we should disable alpha features in the tests (see #52365). And then; let's progress with this PR :) ... @nicknovitski Yes, I think you should update this PR to 1.13.1 and keep it open.

@nicknovitski nicknovitski changed the title kubernetes: 1.12.3 -> 1.13.0 kubernetes: 1.12.3 -> 1.13.1 Dec 17, 2018
@nicknovitski
Copy link
Contributor Author

@johanot Updated to 1.13.1.

@johanot
Copy link
Contributor

johanot commented Dec 17, 2018

@GrahamcOfBorg build kubernetes

johanot
johanot approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@johanot johanot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. RBAC and DNS test cases run clean locally when rebased with master.

@fpletz fpletz merged commit 0334864 into NixOS:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanot johanot johanot approved these changes

Assignees

@srhb srhb

Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nicknovitski @srhb @johanot @fpletz @globin @GrahamcOfBorg