Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson: 0.48.2 → 0.49.0 #51890

Merged
merged 1 commit into from Dec 12, 2018
Merged

meson: 0.48.2 → 0.49.0 #51890

merged 1 commit into from Dec 12, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 11, 2018 •
edited

Motivation for this change

http://mesonbuild.com/Release-notes-for-0-49-0.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar changed the base branch from master to staging December 11, 2018 23:21
@jtojnar jtojnar requested a review from hedning December 11, 2018 23:22
hedning
hedning approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I built a tiny random sampling of the changed packages, including extra-utils just in case, no problems.

hedning
hedning reviewed Dec 12, 2018
View reviewed changes
pkgs/development/tools/build-managers/meson/fix-rpath.patch
if p == from_dir:
relative = '' # relpath errors out in this case
+ elif os.path.isabs(p):
+ relative = p # These can be outside of build dir.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone is wondering. this behavior is now upstream.

@jtojnar jtojnar merged commit 3f1a785 into NixOS:staging Dec 12, 2018
@jtojnar jtojnar deleted the meson-0.49 branch December 12, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @hedning @GrahamcOfBorg