Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nar-info-disk-cache: include ca in the cache entries #2572

Merged
merged 1 commit into from Dec 12, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Dec 12, 2018

Without this information the content addressable state and hashes are lost after the first request, this causes signatures to be required for everything even tho the path could be verified without signing.

$ rm -r ~/.cache/nix
$ nix path-info --store https://cache /nix/store/6j01qy6rj13q5nibm4gpmlv6x7sfgim8-foo --sigs
[0.0 MiB DL]
/nix/store/6j01qy6rj13q5nibm4gpmlv6x7sfgim8-foo ca:text:sha256:0schdl901lnx98l7gmm33x5jvz2xsshli0f15nwm7z7igxjv30vz

$ nix path-info --store https://cache /nix/store/6j01qy6rj13q5nibm4gpmlv6x7sfgim8-foo --sigs
/nix/store/6j01qy6rj13q5nibm4gpmlv6x7sfgim8-foo

Requiring signatures for everything might be nice as an optional setting, but the current behaviour looks like a bug.

Without this information the content addressable state and hashes are
lost after the first request, this causes signatures to be required for
everything even tho the path could be verified without signing.
@edolstra edolstra merged commit 03ce0c3 into NixOS:master Dec 12, 2018
@edolstra
Copy link
Member

Thanks, good catch :-)

@LnL7 LnL7 deleted the narinfo-ca branch December 12, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants