Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.topicons-plus: 21 -> 22 #51910

Merged
merged 1 commit into from Dec 13, 2018
Merged

Conversation

etu
Copy link
Contributor

@etu etu commented Dec 12, 2018

Motivation for this change

This extension seemed to break with gnome 3.30, but according to the website it should work with this newer version.

I have only tested the build though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @jtojnar

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Dec 12, 2018
@Mic92 Mic92 requested a review from jtojnar December 12, 2018 17:28
@jtojnar
Copy link
Contributor

jtojnar commented Dec 12, 2018

@etu
Copy link
Contributor Author

etu commented Dec 13, 2018

Today when I got in to work I was sick of not seeing my notification counters from various programs. So I did an override to this version in my config and can confirm it working on latest unstable.

@emanueleperuffo
Copy link
Contributor

Looks good.
I've moved away from Gnome though 😅.

@hedning hedning merged commit 4a8e6b5 into NixOS:master Dec 13, 2018
@etu etu deleted the update-topicons branch December 13, 2018 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants