Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.secretstorage: 2.3.1 -> 3.1.0 #51904

Merged
merged 2 commits into from Dec 12, 2018
Merged

python3Packages.secretstorage: 2.3.1 -> 3.1.0 #51904

merged 2 commits into from Dec 12, 2018

Conversation

worldofpeace
Copy link
Contributor

Changelog: https://github.com/mitya57/secretstorage/blob/master/changelog

Pertinent changes:

  • ported from dbus-python to jeepney
    Thusly Python 3.5 or newer is required.
  • We can use pypi
  • Add pygobject3
Motivation for this change

This comment from @Mic92 #51269 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.secretstorage python3Packages.keyring

@worldofpeace worldofpeace force-pushed the secretstorage/3.1.0 branch 2 times, most recently from 96650d7 to ae58314 Compare December 12, 2018 14:24
@worldofpeace
python3Packages.jeepney: init at 0.4
9f66479
@worldofpeace
python3Packages.secretstorage: 2.3.1 -> 3.1.0
851e2c7 
Changelog: https://github.com/mitya57/secretstorage/blob/master/changelog

Pertinent changes:

- ported from dbus-python to jeepney
  Thusly Python 3.5 or newer is required.
- We can use pypi
- Add pygobject3
@worldofpeace
Copy link
Contributor Author

@dotlambda I've corrected #51904 (comment)
Also noticed that jeepney didn't have a license so i added that.

So here's the things I've done to test:

  • Ran nix-review successfully (unrelated cached failures ignored)
  • Tested examples for jeepney in a running session with dbus

And did what I was here to do in the first place, which was to make pgcli execute successfully 👍

@dotlambda dotlambda merged commit 34f0481 into NixOS:master Dec 12, 2018
@worldofpeace worldofpeace deleted the secretstorage/3.1.0 branch December 12, 2018 17:15
@jtojnar jtojnar mentioned this pull request Apr 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @Mic92 @dotlambda @GrahamcOfBorg