Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insomnia: 6.0.2 -> 6.2.0 #50906

Merged
merged 1 commit into from Nov 23, 2018
Merged

insomnia: 6.0.2 -> 6.2.0 #50906

merged 1 commit into from Nov 23, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #50724

We needed a few more dependencies to have it working.

In particular the application wouldn't function without stdenv.cc.cc in LD_LIBRARY_PATH.
screenshot from 2018-11-21 22 04 41

Also switch to using autoPatchelfHook.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@worldofpeace
insomnia: 6.0.2 -> 6.2.0
3f478e8 
- Switch to using autoPatchelfHook
- Add some new deps needed for this version

In particular the application won't function without `stdenv.cc.cc`
in LD_LIBRARY_PATH.
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: insomnia

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: insomnia

Partial log (click to expand)

  libnspr4.so -> found: /nix/store/93w914f7mnhhsck2f5jwlbbxv9hgr86z-nspr-4.20/lib/libnspr4.so
  libffmpeg.so -> found: /nix/store/6j5ml8ijdrp1092r53gzk28dcjlmk6s5-insomnia-6.2.0/lib/libffmpeg.so
  libasound.so.2 -> found: /nix/store/720n32zm5w9nbq7zz6ibad4ab7sg3vn2-alsa-lib-1.1.7/lib/libasound.so.2
  libcups.so.2 -> found: /nix/store/ip7b09ks2c7qzzszfkmjvapi151pjkpw-cups-2.2.6-lib/lib/libcups.so.2
  libfontconfig.so.1 -> found: /nix/store/f5aq9p3v96n0jdviaj6iska38z06vaqb-fontconfig-2.12.6-lib/lib/libfontconfig.so.1
  libexpat.so.1 -> found: /nix/store/2gfw7fiss8m86mmjfcf45n3i60xyhk33-expat-2.2.6/lib/libexpat.so.1
setting RPATH to: /nix/store/6j5ml8ijdrp1092r53gzk28dcjlmk6s5-insomnia-6.2.0/lib:/nix/store/66h9b9qanqjd848nh0cxhhn4daj5f19l-gtk+3-3.22.30/lib:/nix/store/66h9b9qanqjd848nh0cxhhn4daj5f19l-gtk+3-3.22.30/lib:/nix/store/d7axxsgwsbh2isjgv813z7chnhp66v4p-pango-1.42.4/lib:/nix/store/d7axxsgwsbh2isjgv813z7chnhp66v4p-pango-1.42.4/lib:/nix/store/b3ca42n3vkaa85a9ivdl310izswcma4r-atk-2.28.1/lib:/nix/store/vgjgw273fl8yx6iljnagzgfzlf09rhxn-cairo-1.16.0/lib:/nix/store/cp0w3abqg4f57xw04z0k53g3q3p57b3r-gdk-pixbuf-2.36.12/lib:/nix/store/9vfvinsf2blx98nqxhxgs4csna3v88jn-glib-2.56.0/lib:/nix/store/9vfvinsf2blx98nqxhxgs4csna3v88jn-glib-2.56.0/lib:/nix/store/b8vp3w9ckczdg38wp3p6pjqixdvf1vfc-at-spi2-atk-2.26.2/lib:/nix/store/da43a7cy7b4yxlh6da5fjdi95fh10agb-dbus-1.12.10-lib/lib:/nix/store/igkgqwdrxbj3980lsbmc1lawgmn79frf-libX11-1.6.6/lib:/nix/store/k9hkf1kch3y3gfp1cjfnfppn43g27jq8-libxcb-1.13.1/lib:/nix/store/qjpvc33cfyi2c82a50459w5v3x16jzjl-libXi-1.7.9/lib:/nix/store/ai26lxxkj05792z57y2zrwbmbajcb0kc-libXcursor-1.1.15/lib:/nix/store/smmj9c954l6i0sib24mzmb0gs01agm5r-libXdamage-1.1.4/lib:/nix/store/87wrz5bw83sa25bdxa2zszhr20qzwd4m-libXrandr-1.5.1/lib:/nix/store/pmyad8xy9a2ppqzq2g6zdg2g4qjswdf5-libXcomposite-0.4.4/lib:/nix/store/nx7na47silpayvq08ip6qn1ds478a7d7-libXext-1.3.3/lib:/nix/store/vlkg2q9bigb1hk73qgjaw4d5qg73ssy1-libXfixes-5.0.3/lib:/nix/store/5b9fji2bg51dw5v1an6ryvnm5adrzzpd-libXrender-0.9.10/lib:/nix/store/igkgqwdrxbj3980lsbmc1lawgmn79frf-libX11-1.6.6/lib:/nix/store/wri6b6m49vbfjxq5fplv9lgxph4cnsxg-libXtst-1.2.3/lib:/nix/store/4g5xdbd47d0a75yl6v3l3fc40chqaaj5-libXScrnSaver-1.2.2/lib:/nix/store/9vfvinsf2blx98nqxhxgs4csna3v88jn-glib-2.56.0/lib:/nix/store/yhvjkyyb0jx0vsb5pd16gr04j1rlvwbc-nss-3.39/lib:/nix/store/yhvjkyyb0jx0vsb5pd16gr04j1rlvwbc-nss-3.39/lib:/nix/store/yhvjkyyb0jx0vsb5pd16gr04j1rlvwbc-nss-3.39/lib:/nix/store/93w914f7mnhhsck2f5jwlbbxv9hgr86z-nspr-4.20/lib:/nix/store/6j5ml8ijdrp1092r53gzk28dcjlmk6s5-insomnia-6.2.0/lib:/nix/store/720n32zm5w9nbq7zz6ibad4ab7sg3vn2-alsa-lib-1.1.7/lib:/nix/store/ip7b09ks2c7qzzszfkmjvapi151pjkpw-cups-2.2.6-lib/lib:/nix/store/f5aq9p3v96n0jdviaj6iska38z06vaqb-fontconfig-2.12.6-lib/lib:/nix/store/2gfw7fiss8m86mmjfcf45n3i60xyhk33-expat-2.2.6/lib
searching for dependencies of /nix/store/6j5ml8ijdrp1092r53gzk28dcjlmk6s5-insomnia-6.2.0/lib/libffmpeg.so
searching for dependencies of /nix/store/6j5ml8ijdrp1092r53gzk28dcjlmk6s5-insomnia-6.2.0/lib/libnode.so
/nix/store/6j5ml8ijdrp1092r53gzk28dcjlmk6s5-insomnia-6.2.0

@aanderse
Copy link
Member

Changelog: https://insomnia.rest/changelog/6.2.0

@c0bw3b c0bw3b mentioned this pull request Nov 22, 2018
Closed
@worldofpeace worldofpeace merged commit f591dd2 into NixOS:master Nov 23, 2018
@worldofpeace worldofpeace deleted the insomnia/6.2.0 branch November 23, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @GrahamcOfBorg @aanderse