Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golint: 20180208 -> 20181026 #50908

Merged
merged 1 commit into from Nov 23, 2018
Merged

golint: 20180208 -> 20181026 #50908

merged 1 commit into from Nov 23, 2018

Conversation

jhillyerd
Copy link
Contributor

@jhillyerd jhillyerd commented Nov 22, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

This was referenced Nov 22, 2018
Merged
Closed
@jhillyerd
golint: 20180208 -> 20181026
bd3810a 
- golint has moved from github to golang.org/x/lint
- allowGoReferences must be true, fixes NixOS#50907
@srhb
Copy link
Contributor

srhb commented Nov 23, 2018

@GrahamcOfBorg eval
@GrahamcOfBorg build golint

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: golint

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/91a7ddlspg14fw601cwy8vvggmr6a1yz-lint-20181026-c67002c-bin
shrinking /nix/store/91a7ddlspg14fw601cwy8vvggmr6a1yz-lint-20181026-c67002c-bin/bin/golint
cannot find section .dynamic
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/91a7ddlspg14fw601cwy8vvggmr6a1yz-lint-20181026-c67002c-bin/bin
patching script interpreter paths in /nix/store/91a7ddlspg14fw601cwy8vvggmr6a1yz-lint-20181026-c67002c-bin
checking for references to /build in /nix/store/91a7ddlspg14fw601cwy8vvggmr6a1yz-lint-20181026-c67002c-bin...
cannot find section .dynamic
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
/nix/store/91a7ddlspg14fw601cwy8vvggmr6a1yz-lint-20181026-c67002c-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: golint

Partial log (click to expand)

find: '/nix/store/301dsa661bfh86cxfnndqgk7bn46fakk-lint-20181026-c67002c': No such file or directory
find: '/nix/store/301dsa661bfh86cxfnndqgk7bn46fakk-lint-20181026-c67002c': No such file or directory
find: '/nix/store/301dsa661bfh86cxfnndqgk7bn46fakk-lint-20181026-c67002c': No such file or directory
find: '/nix/store/301dsa661bfh86cxfnndqgk7bn46fakk-lint-20181026-c67002c': No such file or directory
find: '/nix/store/301dsa661bfh86cxfnndqgk7bn46fakk-lint-20181026-c67002c': No such file or directory
find: '/nix/store/301dsa661bfh86cxfnndqgk7bn46fakk-lint-20181026-c67002c': No such file or directory
find: '/nix/store/301dsa661bfh86cxfnndqgk7bn46fakk-lint-20181026-c67002c': No such file or directory
find: '/nix/store/301dsa661bfh86cxfnndqgk7bn46fakk-lint-20181026-c67002c': No such file or directory
find: '/nix/store/301dsa661bfh86cxfnndqgk7bn46fakk-lint-20181026-c67002c': No such file or directory
/nix/store/bs5nbl6zygminlg3842zjwdwbsdl05ap-lint-20181026-c67002c-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: golint

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/n4cvfz8ss0zcalska2j4p65mzpsiy5gc-lint-20181026-c67002c-bin
shrinking /nix/store/n4cvfz8ss0zcalska2j4p65mzpsiy5gc-lint-20181026-c67002c-bin/bin/golint
cannot find section .dynamic
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n4cvfz8ss0zcalska2j4p65mzpsiy5gc-lint-20181026-c67002c-bin/bin
patching script interpreter paths in /nix/store/n4cvfz8ss0zcalska2j4p65mzpsiy5gc-lint-20181026-c67002c-bin
checking for references to /build in /nix/store/n4cvfz8ss0zcalska2j4p65mzpsiy5gc-lint-20181026-c67002c-bin...
cannot find section .dynamic
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
/nix/store/n4cvfz8ss0zcalska2j4p65mzpsiy5gc-lint-20181026-c67002c-bin

@Mic92 Mic92 merged commit 7acd4eb into NixOS:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhillyerd @srhb @GrahamcOfBorg @Mic92