Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openarena: add missing dependency - openal #50903

Merged
merged 1 commit into from Nov 22, 2018
Merged

openarena: add missing dependency - openal #50903

merged 1 commit into from Nov 22, 2018

Conversation

cx405
Copy link

@cx405 cx405 commented Nov 22, 2018

Without this change:
'''
------ Initializing Sound ------
Loading "libopenal.so.1"...
Failed to load library: "libopenal.so.1".
'''

when openal is selected. In addition, upcoming 0.19.1 openal supports 3d positioning audio via stereo (HTRF).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

openarena: add missing dependency - openal
f6ea6a9 
Without this change:
'''
------ Initializing Sound ------
Loading "libopenal.so.1"...
Failed to load library: "libopenal.so.1".
'''

when openal is selected. In addition, upcoming 0.19.1 openal supports 3d positioning audio via stereo (HTRF).
worldofpeace
worldofpeace approved these changes Nov 22, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and executes without this error at runtime.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build openarena

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openarena

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/j02121wjc4kxzz02hx77zxrrkmd61fj3-openarena-0.8.8
shrinking /nix/store/j02121wjc4kxzz02hx77zxrrkmd61fj3-openarena-0.8.8/openarena-0.8.8/oa_ded.i386
shrinking /nix/store/j02121wjc4kxzz02hx77zxrrkmd61fj3-openarena-0.8.8/openarena-0.8.8/oa_ded.x86_64
shrinking /nix/store/j02121wjc4kxzz02hx77zxrrkmd61fj3-openarena-0.8.8/openarena-0.8.8/openarena.i386
shrinking /nix/store/j02121wjc4kxzz02hx77zxrrkmd61fj3-openarena-0.8.8/openarena-0.8.8/openarena.x86_64
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j02121wjc4kxzz02hx77zxrrkmd61fj3-openarena-0.8.8/bin
patching script interpreter paths in /nix/store/j02121wjc4kxzz02hx77zxrrkmd61fj3-openarena-0.8.8
checking for references to /build in /nix/store/j02121wjc4kxzz02hx77zxrrkmd61fj3-openarena-0.8.8...
/nix/store/j02121wjc4kxzz02hx77zxrrkmd61fj3-openarena-0.8.8

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openarena

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/clq6rvdm9ilxlbvn5iwgaq624scsriw7-openarena-0.8.8
shrinking /nix/store/clq6rvdm9ilxlbvn5iwgaq624scsriw7-openarena-0.8.8/openarena-0.8.8/oa_ded.x86_64
shrinking /nix/store/clq6rvdm9ilxlbvn5iwgaq624scsriw7-openarena-0.8.8/openarena-0.8.8/openarena.x86_64
shrinking /nix/store/clq6rvdm9ilxlbvn5iwgaq624scsriw7-openarena-0.8.8/openarena-0.8.8/oa_ded.i386
shrinking /nix/store/clq6rvdm9ilxlbvn5iwgaq624scsriw7-openarena-0.8.8/openarena-0.8.8/openarena.i386
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/clq6rvdm9ilxlbvn5iwgaq624scsriw7-openarena-0.8.8/bin
patching script interpreter paths in /nix/store/clq6rvdm9ilxlbvn5iwgaq624scsriw7-openarena-0.8.8
checking for references to /build in /nix/store/clq6rvdm9ilxlbvn5iwgaq624scsriw7-openarena-0.8.8...
/nix/store/clq6rvdm9ilxlbvn5iwgaq624scsriw7-openarena-0.8.8

@worldofpeace worldofpeace merged commit 8719126 into NixOS:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cx405 @worldofpeace @GrahamcOfBorg @Janik-Haag