pythonPackages.docutils: fix python3 build #50886
Merged
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: python
8.has: documentation
There was a problem hiding this comment.
@marsam
It's helpful if you describe what failure you were fixing, the output, and what platform you experienced this.
After digging around at https://hydra.nixos.org to look for the failure, as I couldn't reproduce this on linux, I found that this was only a problem for darwin. See https://hydra.nixos.org/build/84046228.
running install tests
Traceback (most recent call last):
File "test3/alltests.py", line 80, in <module>
suite = suite()
File "test3/alltests.py", line 69, in suite
'test_', packages=1)
File "/private/tmp/nix-build-python3.7-docutils-0.14.drv-0/docutils-0.14/test3/package_unittest.py", line 101, in loadTestModules
module = import_module(mod)
File "/private/tmp/nix-build-python3.7-docutils-0.14.drv-0/docutils-0.14/test3/package_unittest.py", line 132, in import_module
mod = __import__(name)
File "/private/tmp/nix-build-python3.7-docutils-0.14.drv-0/docutils-0.14/test3/test_command_line.py", line 19, in <module>
locale_encoding = locale.getlocale()[1] or locale.getdefaultlocale()[1]
File "/nix/store/ky86n177vy9h4vi62vjzsv96b4pywiwv-python3-3.7.1/lib/python3.7/locale.py", line 587, in getlocale
return _parse_localename(localename)
File "/nix/store/ky86n177vy9h4vi62vjzsv96b4pywiwv-python3-3.7.1/lib/python3.7/locale.py", line 495, in _parse_localename
raise ValueError('unknown locale: %s' % localename)
ValueError: unknown locale: UTF-8
As for the changes, they appear to be usual way to fix this.
Also maybe fix python3 build on darwin would be clearer in the commit msg.
|
@GrahamcOfBorg build python3Packages.docutils |
|
Success on x86_64-linux (full log) Attempted: python3Packages.docutils Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python3Packages.docutils Partial log (click to expand)
|
LnL7
reviewed
Nov 21, 2018
| ${python.interpreter} test3/alltests.py | ||
| '' else '' | ||
| ${python.interpreter} test/alltests.py | ||
| checkInputs = [ glibcLocales ]; |
There was a problem hiding this comment.
glibcLocales is a linux only dependency, just setting LANG should be enough to fix the issue mentioned above.
There was a problem hiding this comment.
I've removed glibcLocales, and checked if still works 👍
There was a problem hiding this comment.
In some cases you do want it on linux, but then it needs a conditional.
|
@GrahamcOfBorg build python3Packages.docutils |
|
Success on aarch64-linux (full log) Attempted: python3Packages.docutils Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python3Packages.docutils Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: python3Packages.docutils Partial log (click to expand)
|
|
@infinisil It's whatever I guess 🤣 |
LnL7
approved these changes
Nov 21, 2018
|
@marsam |
|
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/move-python37packages-docutils-fix-to-master/1622/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)