Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netdata: create missing /etc/netdata #50899

Merged
merged 1 commit into from Nov 21, 2018
Merged

netdata: create missing /etc/netdata #50899

merged 1 commit into from Nov 21, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 21, 2018 •
edited

Motivation for this change

Since netdata 1.11.0 updated in #50459
it needs to have a /etc/netdata directory, which we did not create by default.
fixes #50893

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
netdata: create missing /etc/netdata
769735d 
Since netdata 1.11.0 updated in NixOS#50459
it needs to have a /etc/netdata directory, which we did not create by default.
fixes NixOS#50893
@Mic92
Copy link
Member Author

Mic92 commented Nov 21, 2018

@GrahamcOfBorg build nixosTests.netdata

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: nixosTests.netdata

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14334:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14334:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14632:16, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14632:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:51:1

@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 21, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nixosTests.netdata

Partial log (click to expand)

netdata: exit status 1
syncing
netdata: running command: sync
netdata: exit status 0
test script finished in 12.03s
cleaning up
killing netdata (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/3gb8w296fcqcinnb1yic6wjhx4g6pp0n-vm-test-run-netdata

@Mic92 Mic92 merged commit 494e290 into NixOS:master Nov 21, 2018
@Mic92
Copy link
Member Author

Mic92 commented Nov 21, 2018

backport: 21517c6

@Mic92 Mic92 deleted the netdata-etc branch November 21, 2018 23:13
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: netdata

Partial log (click to expand)

/nix/store/q8vgb8w371ymdb1c2vp4n7k5m4wg8amr-netdata-1.11.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: netdata

Partial log (click to expand)

/nix/store/2pchg5jqz7z8b4d5aawz9wp0i0dhlfjw-netdata-1.11.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: netdata

Partial log (click to expand)

these paths will be fetched (1.63 MiB download, 7.09 MiB unpacked):
  /nix/store/5di6k0y3md460qyl633z8r2kvij95hr7-netdata-1.11.0
  /nix/store/c67c8rh7r8z4f00xna4x4scrppgkydjv-libossp-uuid-1.6.2
copying path '/nix/store/c67c8rh7r8z4f00xna4x4scrppgkydjv-libossp-uuid-1.6.2' from 'https://cache.nixos.org'...
copying path '/nix/store/5di6k0y3md460qyl633z8r2kvij95hr7-netdata-1.11.0' from 'https://cache.nixos.org'...
/nix/store/5di6k0y3md460qyl633z8r2kvij95hr7-netdata-1.11.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nixosTests.netdata

Partial log (click to expand)

netdata: exit status 1
syncing
netdata: running command: sync
netdata: exit status 0
test script finished in 18.23s
cleaning up
killing netdata (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/32rd6p4nbh0wjlhqahilgsq4hlfa4593-vm-test-run-netdata

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

netdata is broken
3 participants
@Mic92 @GrahamcOfBorg @samueldr