Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-cbindgen: 0.6.3 -> 0.6.7 #50349

Merged
merged 2 commits into from
Nov 14, 2018
Merged

rust-cbindgen: 0.6.3 -> 0.6.7 #50349

merged 2 commits into from
Nov 14, 2018
+11 −3

Conversation

andir
Copy link
Member

@andir andir commented Nov 14, 2018

Motivation for this change

Updated rust-cbindgen since we will need a newer version for the upcoming firefox 64 release.

I am currently rebuilding firefox on one of my machines.

This will require backporting for future firefox updates.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

/cc @jtojnar

Sorry, something went wrong.

@andir andir added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 14, 2018
@andir andir requested a review from dywedir November 14, 2018 13:36
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rust-cbindgen

Partial log (click to expand)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/xxmj2rnqbjpmywg8hv4ar7nzynch1rh3-rust-cbindgen-0.6.7/bin
patching script interpreter paths in /nix/store/xxmj2rnqbjpmywg8hv4ar7nzynch1rh3-rust-cbindgen-0.6.7
/nix/store/xxmj2rnqbjpmywg8hv4ar7nzynch1rh3-rust-cbindgen-0.6.7

@andir
Copy link
Member Author

andir commented Nov 14, 2018

the firefox build failes with

stack backtrace:
   0:     0x7ffff764190e - std::sys::unix::backtrace::tracing::imp::unwind_backtrace::h1298aff7c07c67ca
   1:     0x7ffff7654da2 - std::panicking::default_hook::{{closure}}::hb90d1cb6a98fd361
   2:     0x7ffff765433b - std::panicking::default_hook::h856803d056376eda
   3:     0x7ffff7655abc - std::panicking::rust_panic_with_hook::h480f4a14b65756a6
   4:     0x7ffff7655679 - std::panicking::continue_panic_fmt::h8c2ee3ce2bcded8d
   5:     0x7ffff76555dd - std::panicking::begin_panic_fmt::h0002fa8629b585ad
   6:     0x55555559c48b - build_script_build::build_gecko::bindings::write_binding_file::h8e44a113854fb068
   7:     0x55555559feb8 - build_script_build::build_gecko::bindings::generate_structs::h8d7e998605178f9f
   8:     0x7ffff7684919 - __rust_maybe_catch_panic
   9:     0x55555558fe6b - <F as alloc::boxed::FnBox<A>>::call_box::hb54273f07b0de208
  10:     0x7ffff764602a - std::sys_common::thread::start_thread::hebf8eedc34a4d3b4
  11:     0x7ffff7656845 - std::sys::unix::thread::Thread::new::thread_start::h65266df00b7a2b70
  12:     0x7ffff7bc05a6 - start_thread
  13:     0x7ffff6f1522e - __GI___clone
  14:                0x0 - <unknown>
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Any', libcore/result.rs:1009:5
stack backtrace:
   0:     0x7ffff764190e - std::sys::unix::backtrace::tracing::imp::unwind_backtrace::h1298aff7c07c67ca
   1:     0x7ffff7654da2 - std::panicking::default_hook::{{closure}}::hb90d1cb6a98fd361
   2:     0x7ffff765433b - std::panicking::default_hook::h856803d056376eda
   3:     0x7ffff7655abc - std::panicking::rust_panic_with_hook::h480f4a14b65756a6
   4:     0x7ffff7655679 - std::panicking::continue_panic_fmt::h8c2ee3ce2bcded8d
   5:     0x7ffff7655575 - rust_begin_unwind
   6:     0x7ffff76ef53b - core::panicking::panic_fmt::h5ac035283b460341
   7:     0x55555558faea - core::result::unwrap_failed::he9ca5f2aa42bd9c6
   8:     0x5555555a5bf8 - build_script_build::main::hb7f27a533cf48842
   9:     0x555555589142 - std::rt::lang_start::{{closure}}::h5a39051669cce92e
  10:     0x7ffff7655512 - std::panicking::try::do_call::hd978816942bf1315
  11:     0x7ffff7684919 - __rust_maybe_catch_panic
  12:     0x7ffff766ed65 - std::rt::lang_start_internal::h00c3c4a30f67a2d3
  13:     0x5555555a5ff3 - main
  14:     0x7ffff6e44b8d - __libc_start_main
  15:     0x5555555845e9 - _start
                               at ../sysdeps/x86_64/start.S:120
  16:                0x0 - <unknown>

Will have a look later today.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rust-cbindgen

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q5lrz7lq64yy0cqvzqhas6q7g4sy9xwx-rust-cbindgen-0.6.7
shrinking /nix/store/q5lrz7lq64yy0cqvzqhas6q7g4sy9xwx-rust-cbindgen-0.6.7/bin/cbindgen
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q5lrz7lq64yy0cqvzqhas6q7g4sy9xwx-rust-cbindgen-0.6.7/bin
patching script interpreter paths in /nix/store/q5lrz7lq64yy0cqvzqhas6q7g4sy9xwx-rust-cbindgen-0.6.7
checking for references to /build in /nix/store/q5lrz7lq64yy0cqvzqhas6q7g4sy9xwx-rust-cbindgen-0.6.7...
/nix/store/q5lrz7lq64yy0cqvzqhas6q7g4sy9xwx-rust-cbindgen-0.6.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rust-cbindgen

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qx14dbajpkjn4pxpl5ypaj4fidkki414-rust-cbindgen-0.6.7
shrinking /nix/store/qx14dbajpkjn4pxpl5ypaj4fidkki414-rust-cbindgen-0.6.7/bin/cbindgen
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qx14dbajpkjn4pxpl5ypaj4fidkki414-rust-cbindgen-0.6.7/bin
patching script interpreter paths in /nix/store/qx14dbajpkjn4pxpl5ypaj4fidkki414-rust-cbindgen-0.6.7
checking for references to /build in /nix/store/qx14dbajpkjn4pxpl5ypaj4fidkki414-rust-cbindgen-0.6.7...
/nix/store/qx14dbajpkjn4pxpl5ypaj4fidkki414-rust-cbindgen-0.6.7

@dywedir
Copy link
Member

dywedir commented Nov 14, 2018 •
edited
Loading

the firefox build failes with

Probably related: https://git.archlinux.org/svntogit/packages.git/tree/trunk/0001-Keep-mozilla-release-building-with-newer-cbindgen-ve.patch

andir added 2 commits November 14, 2018 19:53
@andir
rust-cbindgen: 0.6.3 -> 0.6.7

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
f1ee26b
@andir
firefox: apply patch for newer rust-cbindgen
66e1684 
rust-cbindgen did apply some breaking changes which requires the added
patch in order to compile until a firefox version with the fix gets
released. Firefox 63.0.3 is supposed to carry the required patches. This
should only be required for a short term.
@andir
Copy link
Member Author

andir commented Nov 14, 2018

@dywedir thanks for pointing me in the right direction. I picked the commit from the 63.0.3 release (pending) and applied it instead.

Running the rebuilds just now.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rust-cbindgen

Partial log (click to expand)

/nix/store/qx14dbajpkjn4pxpl5ypaj4fidkki414-rust-cbindgen-0.6.7

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rust-cbindgen

Partial log (click to expand)

/nix/store/xxmj2rnqbjpmywg8hv4ar7nzynch1rh3-rust-cbindgen-0.6.7

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rust-cbindgen

Partial log (click to expand)

/nix/store/q5lrz7lq64yy0cqvzqhas6q7g4sy9xwx-rust-cbindgen-0.6.7

dywedir
dywedir approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@dywedir dywedir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@andir
Copy link
Member Author

andir commented Nov 14, 2018

Rebuild succeeded. Looks good to me :-)

@andir andir merged commit 34665b1 into NixOS:master Nov 14, 2018
@andir andir deleted the rust-cbindgen branch November 14, 2018 22:02
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @GrahamcOfBorg @dywedir @samueldr