Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elfinfo: init at 0.7.4 #50357

Merged
merged 1 commit into from Nov 15, 2018
Merged

elfinfo: init at 0.7.4 #50357

merged 1 commit into from Nov 15, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 14, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: elfinfo

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/afz0a066lydyz158ig3radbrdmrpi31g-elfinfo-0.7.4-bin
shrinking /nix/store/afz0a066lydyz158ig3radbrdmrpi31g-elfinfo-0.7.4-bin/bin/elfinfo
cannot find section .dynamic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/afz0a066lydyz158ig3radbrdmrpi31g-elfinfo-0.7.4-bin/bin
patching script interpreter paths in /nix/store/afz0a066lydyz158ig3radbrdmrpi31g-elfinfo-0.7.4-bin
checking for references to /build in /nix/store/afz0a066lydyz158ig3radbrdmrpi31g-elfinfo-0.7.4-bin...
cannot find section .dynamic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/afz0a066lydyz158ig3radbrdmrpi31g-elfinfo-0.7.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: elfinfo

Partial log (click to expand)

find: '/nix/store/zdiy325f0qb7rac79vzfpg7xj549x93b-elfinfo-0.7.4': No such file or directory
find: '/nix/store/zdiy325f0qb7rac79vzfpg7xj549x93b-elfinfo-0.7.4': No such file or directory
find: '/nix/store/zdiy325f0qb7rac79vzfpg7xj549x93b-elfinfo-0.7.4': No such file or directory
find: '/nix/store/zdiy325f0qb7rac79vzfpg7xj549x93b-elfinfo-0.7.4': No such file or directory
find: '/nix/store/zdiy325f0qb7rac79vzfpg7xj549x93b-elfinfo-0.7.4': No such file or directory
find: '/nix/store/zdiy325f0qb7rac79vzfpg7xj549x93b-elfinfo-0.7.4': No such file or directory
find: '/nix/store/zdiy325f0qb7rac79vzfpg7xj549x93b-elfinfo-0.7.4': No such file or directory
find: '/nix/store/zdiy325f0qb7rac79vzfpg7xj549x93b-elfinfo-0.7.4': No such file or directory
find: '/nix/store/zdiy325f0qb7rac79vzfpg7xj549x93b-elfinfo-0.7.4': No such file or directory
/nix/store/jsp311bh6m7p2m9z4ndyp6ixcndwa4lz-elfinfo-0.7.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: elfinfo

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/id2mvxj9i1h2d8yw3fj0cbi88arsf0l1-elfinfo-0.7.4-bin
shrinking /nix/store/id2mvxj9i1h2d8yw3fj0cbi88arsf0l1-elfinfo-0.7.4-bin/bin/elfinfo
cannot find section .dynamic
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/id2mvxj9i1h2d8yw3fj0cbi88arsf0l1-elfinfo-0.7.4-bin/bin
patching script interpreter paths in /nix/store/id2mvxj9i1h2d8yw3fj0cbi88arsf0l1-elfinfo-0.7.4-bin
checking for references to /build in /nix/store/id2mvxj9i1h2d8yw3fj0cbi88arsf0l1-elfinfo-0.7.4-bin...
cannot find section .dynamic
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/id2mvxj9i1h2d8yw3fj0cbi88arsf0l1-elfinfo-0.7.4-bin

worldofpeace
worldofpeace approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and it works fine. 👍

@dtzWill dtzWill merged commit b1e5910 into NixOS:master Nov 15, 2018
@dtzWill dtzWill deleted the feature/elfinfo branch November 15, 2018 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @worldofpeace