Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.menhir: 20181026 -> 20181113 #50353

Merged
merged 1 commit into from Nov 21, 2018
Merged

ocamlPackages.menhir: 20181026 -> 20181113 #50353

merged 1 commit into from Nov 21, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 14, 2018

Motivation for this change

New rule syntax.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

Is the old still valid?

@vbgl
Copy link
Contributor Author

vbgl commented Nov 14, 2018

Quoting from the change log:

The old syntax remains available; the user chooses between the two syntaxes on a per-rule basis.

@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

Sounds good. Then the upgrade should be not a big deal.

@vbgl vbgl merged commit 88d20b2 into NixOS:master Nov 21, 2018
@vbgl vbgl deleted the ocaml-menhir-20181113 branch November 21, 2018 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @Mic92 @GrahamcOfBorg