Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: fix smtp setting #50356

Merged
merged 1 commit into from Nov 15, 2018
Merged

gitlab: fix smtp setting #50356

merged 1 commit into from Nov 15, 2018

Conversation

globin
Copy link
Member

@globin globin commented Nov 14, 2018

fixes #50163

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • N/A macOS
    • N/A other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • N/A Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • N/A Tested execution of all binary files (usually in ./result/bin/)
  • N/A Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @lheckemann @flokli @krav @fpletz

@globin globin changed the title gitlab: fix stmp setting gitlab: fix smtp setting Nov 14, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gitlab

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gitlab

Partial log (click to expand)

/nix/store/8inpzli40myq31khb8dpd65qap8wmaf7-gitlab-11.4.4/share/gitlab/bin/parallel-rsync-repos: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/8inpzli40myq31khb8dpd65qap8wmaf7-gitlab-11.4.4/share/gitlab/bin/mail_room: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/8inpzli40myq31khb8dpd65qap8wmaf7-gitlab-11.4.4/share/gitlab/bin/daemon_with_pidfile: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/53n9axmp5h00zqhb7a88y2wkmk1jdwh5-wrapped-ruby-gitlab-env-11.4.4/bin/ruby"
/nix/store/8inpzli40myq31khb8dpd65qap8wmaf7-gitlab-11.4.4/share/gitlab/bin/check: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/8inpzli40myq31khb8dpd65qap8wmaf7-gitlab-11.4.4/share/gitlab/bin/changelog: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/53n9axmp5h00zqhb7a88y2wkmk1jdwh5-wrapped-ruby-gitlab-env-11.4.4/bin/ruby"
/nix/store/8inpzli40myq31khb8dpd65qap8wmaf7-gitlab-11.4.4/share/gitlab/bin/bundle: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/53n9axmp5h00zqhb7a88y2wkmk1jdwh5-wrapped-ruby-gitlab-env-11.4.4/bin/ruby"
/nix/store/8inpzli40myq31khb8dpd65qap8wmaf7-gitlab-11.4.4/share/gitlab/bin/background_jobs: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
/nix/store/8inpzli40myq31khb8dpd65qap8wmaf7-gitlab-11.4.4/share/gitlab/Rakefile: interpreter directive changed from "/usr/bin/env rake" to "/nix/store/955vcqyhnd1dp7s8cj5szy73w0cxzipv-gitlab-env-11.4.4/bin/rake"
checking for references to /build in /nix/store/8inpzli40myq31khb8dpd65qap8wmaf7-gitlab-11.4.4...
/nix/store/8inpzli40myq31khb8dpd65qap8wmaf7-gitlab-11.4.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitlab

Partial log (click to expand)

copying path '/nix/store/z459q9p7yd3n35nvly2g788qhdgn9jap-ruby2.5.3-rspec_profiling-0.0.5' from 'https://cache.nixos.org'...
copying path '/nix/store/dq4xfxzh50p9arw19bwvpa4hffpdixqw-ruby2.5.3-warden-1.2.7' from 'https://cache.nixos.org'...
copying path '/nix/store/7awdys3a0hzxybn769pzk1zqkw2abxnh-ruby2.5.3-webpack-rails-0.9.11' from 'https://cache.nixos.org'...
copying path '/nix/store/ffa7qr700dwpk22kl0bwcyqp627kip21-ruby2.5.3-devise-4.4.3' from 'https://cache.nixos.org'...
copying path '/nix/store/mrrp9kr13jxv11sy105pndqb21hybg16-ruby2.5.3-devise-two-factor-3.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/gjbz4fdrwhjvwf963vga5jnxa0ckdmza-gitlab-env-11.4.4' from 'https://cache.nixos.org'...
cannot link '/nix/store/.links/0fabijz3i86js5dxmrj6ijk8np0pc94kqh8b3wizahyfv8d5hz5k' to '/nix/store/gjbz4fdrwhjvwf963vga5jnxa0ckdmza-gitlab-env-11.4.4/lib/ruby/gems/2.5.0/cache/grape-path-helpers-1.0.6.gem': No space left on device
copying path '/nix/store/8fz6pq5yfqsd3n1ng7jwjx93r534p8y0-wrapped-ruby-gitlab-env-11.4.4' from 'https://cache.nixos.org'...
copying path '/nix/store/pzwxys37crpv01hc62kv3q8fwa2n0kf4-gitlab-11.4.4' from 'https://cache.nixos.org'...
/nix/store/pzwxys37crpv01hc62kv3q8fwa2n0kf4-gitlab-11.4.4

@infinisil
Copy link
Member

@GrahamcOfBorg test gitlab

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.gitlab

Partial log (click to expand)

error: while evaluating 'recursiveUpdate' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:415:26, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:384:37, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:21, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:332:33, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:27:
while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/lists.nix:113:41, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:46:
while evaluating the attribute 'gitlab' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:80:3:
while evaluating 'handleTest' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:17:22, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:80:12:
while evaluating 'discoverTests' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:13:19, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:18:5:
access to path '/nix/store/1sc4szycfkaf94s0kg6x63cf52nfldk2-rbvermaa-spot' is forbidden in restricted mode

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.gitlab

Partial log (click to expand)

Cannot nix-instantiate `tests.gitlab' because:
error: while evaluating 'recursiveUpdate' at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/attrsets.nix:415:26, called from /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/attrsets.nix:384:37, called from /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/attrsets.nix:347:21, called from /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/attrsets.nix:332:33, called from /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/lib/attrsets.nix:347:27:
while evaluating the attribute 'gitlab' at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/nixos/tests/all-tests.nix:80:3:
while evaluating 'handleTest' at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/nixos/tests/all-tests.nix:17:22, called from /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/nixos/tests/all-tests.nix:80:12:
while evaluating 'discoverTests' at /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/nixos/tests/all-tests.nix:13:19, called from /var/lib/gc-of-borg/nix-test-rs-12/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-12/nixos/tests/all-tests.nix:18:5:
access to path '/nix/store/943h4xvsgw3gi2qsnqrfaazlrjfgqzbw-grahamc-aarch64-community-12' is forbidden in restricted mode

@lheckemann lheckemann merged commit f73afe6 into NixOS:master Nov 15, 2018
@lheckemann lheckemann deleted the gitlab-smtp-fix branch November 15, 2018 11:13
@flokli
Copy link
Contributor

flokli commented Nov 15, 2018

@lheckemann can you backport to 18.09 as well?

@lheckemann
Copy link
Member

9bf8b0d

@flokli
Copy link
Contributor

flokli commented Nov 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gitlab startup errors since eadb998
5 participants
@globin @GrahamcOfBorg @infinisil @flokli @lheckemann