Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x265: 2.7 -> 2.9 #50362

Merged
merged 1 commit into from Nov 15, 2018
Merged

x265: 2.7 -> 2.9 #50362

merged 1 commit into from Nov 15, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 14, 2018

Motivation for this change

Targeting this at staging since it is quite a big rebuild + source URLs enhancement
Thanks @grische for the original pkg update

Encoder enhancements, AVX-512 support, ...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: x265

Partial log (click to expand)

-- Installing: /nix/store/yxl6qslvxnniz5gpx1d66xvc8jcyraaq-x265-2.9/bin/x265
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yxl6qslvxnniz5gpx1d66xvc8jcyraaq-x265-2.9
shrinking /nix/store/yxl6qslvxnniz5gpx1d66xvc8jcyraaq-x265-2.9/lib/libx265.so.165
shrinking /nix/store/yxl6qslvxnniz5gpx1d66xvc8jcyraaq-x265-2.9/bin/x265
strip is /nix/store/1nj4j6krp1bbmgkfxvs8108n9zl92ak6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yxl6qslvxnniz5gpx1d66xvc8jcyraaq-x265-2.9/lib  /nix/store/yxl6qslvxnniz5gpx1d66xvc8jcyraaq-x265-2.9/bin
patching script interpreter paths in /nix/store/yxl6qslvxnniz5gpx1d66xvc8jcyraaq-x265-2.9
checking for references to /build in /nix/store/yxl6qslvxnniz5gpx1d66xvc8jcyraaq-x265-2.9...
/nix/store/yxl6qslvxnniz5gpx1d66xvc8jcyraaq-x265-2.9

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: x265

Partial log (click to expand)

[ 96%] Building CXX object CMakeFiles/cli.dir/output/yuv.cpp.o
[ 98%] Building CXX object CMakeFiles/cli.dir/x265.cpp.o
[100%] Linking CXX executable x265
libx265.so.165: undefined reference to `x265::detect512()'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/cli.dir/build.make:205: x265] Error 1
make[1]: *** [CMakeFiles/Makefile2:213: CMakeFiles/cli.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for '/nix/store/ikwmknn9m66yqmgwafh7lkjrlcdi64s9-x265-2.9.drv' failed with exit code 2
error: build of '/nix/store/ikwmknn9m66yqmgwafh7lkjrlcdi64s9-x265-2.9.drv' failed

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 14, 2018

Upstream issue for linking failure undefined reference to x265::detect512() on ARM is #442
Fixed with commit 471726d -->I'm going to fetchpatch this

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: x265

Partial log (click to expand)

shrinking /nix/store/72p4banhmcrhqp634spimh7whpmvz2by-cmake-3.12.1/bin/cmake
strip is /nix/store/a6cc0wimnbsrhbgy5axg7lq81akfy32y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/72p4banhmcrhqp634spimh7whpmvz2by-cmake-3.12.1/bin
patching script interpreter paths in /nix/store/72p4banhmcrhqp634spimh7whpmvz2by-cmake-3.12.1
/nix/store/72p4banhmcrhqp634spimh7whpmvz2by-cmake-3.12.1/share/cmake-3.12/Modules/CPack.STGZ_Header.sh.in: interpreter directive changed from "/bin/sh" to "/nix/store/qvjs7hccx24r8cwhvm3h243jq0zw97r5-bash-4.4-p23/bin/sh"
/nix/store/72p4banhmcrhqp634spimh7whpmvz2by-cmake-3.12.1/share/cmake-3.12/Modules/Squish4RunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/qvjs7hccx24r8cwhvm3h243jq0zw97r5-bash-4.4-p23/bin/sh"
/nix/store/72p4banhmcrhqp634spimh7whpmvz2by-cmake-3.12.1/share/cmake-3.12/Modules/SquishRunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/qvjs7hccx24r8cwhvm3h243jq0zw97r5-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/72p4banhmcrhqp634spimh7whpmvz2by-cmake-3.12.1...
cannot build derivation '/nix/store/ifp353kidlxpsfclaqhi05l1j55rxmwy-x265-2.9.drv': 1 dependencies couldn't be built
error: build of '/nix/store/ifp353kidlxpsfclaqhi05l1j55rxmwy-x265-2.9.drv' failed

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: x265

Partial log (click to expand)

shrinking /nix/store/5qq0rlxln2j8jxqy7sv03y16msak208w-cmake-3.12.1/bin/ctest
strip is /nix/store/1nj4j6krp1bbmgkfxvs8108n9zl92ak6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5qq0rlxln2j8jxqy7sv03y16msak208w-cmake-3.12.1/bin
patching script interpreter paths in /nix/store/5qq0rlxln2j8jxqy7sv03y16msak208w-cmake-3.12.1
/nix/store/5qq0rlxln2j8jxqy7sv03y16msak208w-cmake-3.12.1/share/cmake-3.12/Modules/CPack.STGZ_Header.sh.in: interpreter directive changed from "/bin/sh" to "/nix/store/wmy5z3c4j66i5cgn895iingvk90idcj8-bash-4.4-p23/bin/sh"
/nix/store/5qq0rlxln2j8jxqy7sv03y16msak208w-cmake-3.12.1/share/cmake-3.12/Modules/Squish4RunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/wmy5z3c4j66i5cgn895iingvk90idcj8-bash-4.4-p23/bin/sh"
/nix/store/5qq0rlxln2j8jxqy7sv03y16msak208w-cmake-3.12.1/share/cmake-3.12/Modules/SquishRunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/wmy5z3c4j66i5cgn895iingvk90idcj8-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/5qq0rlxln2j8jxqy7sv03y16msak208w-cmake-3.12.1...
cannot build derivation '/nix/store/wczp0479ap1clf2j10xzr3ysc1kqnh6q-x265-2.9.drv': 1 dependencies couldn't be built
error: build of '/nix/store/wczp0479ap1clf2j10xzr3ysc1kqnh6q-x265-2.9.drv' failed

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 15, 2018

@GrahamcOfBorg build x265

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: x265

Partial log (click to expand)

shrinking /nix/store/623f5wz8ccki85qm806c7ffr6jzakw2a-yasm-1.3.0/bin/vsyasm
shrinking /nix/store/623f5wz8ccki85qm806c7ffr6jzakw2a-yasm-1.3.0/bin/ytasm
shrinking /nix/store/623f5wz8ccki85qm806c7ffr6jzakw2a-yasm-1.3.0/bin/yasm
gzipping man pages under /nix/store/623f5wz8ccki85qm806c7ffr6jzakw2a-yasm-1.3.0/share/man/
strip is /nix/store/s2azzxwmnjql93c8xwrdhp48xrmki1yz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/623f5wz8ccki85qm806c7ffr6jzakw2a-yasm-1.3.0/lib  /nix/store/623f5wz8ccki85qm806c7ffr6jzakw2a-yasm-1.3.0/bin
patching script interpreter paths in /nix/store/623f5wz8ccki85qm806c7ffr6jzakw2a-yasm-1.3.0
checking for references to /build in /nix/store/623f5wz8ccki85qm806c7ffr6jzakw2a-yasm-1.3.0...
cannot build derivation '/nix/store/x75962plw7i58dpcgrdpsck19n6m65l0-x265-2.9.drv': 1 dependencies couldn't be built
error: build of '/nix/store/x75962plw7i58dpcgrdpsck19n6m65l0-x265-2.9.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: x265

Partial log (click to expand)

cannot build derivation '/nix/store/zcshj49xh2yhsp1naw4j5jifwga03p5w-perl5.28.0-XML-Parser-2.44.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/dwafcwp7mrkg5vx97cn84h07mnbx0249-intltool-0.51.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/llwjxaig75ip274lcc5biwazc47i6m7j-gnome-doc-utils-0.20.10.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/91icg6avrk26fza7zm1x6r96vz1zclk9-shadow-4.6.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/k3q5j9bjl0pwmvb5ph0a04fgmvwhk7lw-util-linux-2.32.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/48whlrvnrcd4rpk99jfmy6kjsa6b95w8-e2fsprogs-1.44.4.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/xr1i42bpwdk7fvph03siwli66apkn64n-libarchive-3.3.2.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/00h4py4zxsnj6r42h138rah52rly28qc-cmake-3.12.1.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/x8v25xsl8354ng2vcgj9c41653av4023-x265-2.9.drv': 5 dependencies couldn't be built
error: build of '/nix/store/x8v25xsl8354ng2vcgj9c41653av4023-x265-2.9.drv' failed

Encoder enhancements, AVX-512 support, ...

x265: fix linking issue on aarch64
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 15, 2018

@GrahamcOfBorg build x265

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: x265

Partial log (click to expand)

-- Installing: /nix/store/71kbfhfmijf866apm310bm8wm7x5caa7-x265-2.9/bin/x265
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/71kbfhfmijf866apm310bm8wm7x5caa7-x265-2.9
shrinking /nix/store/71kbfhfmijf866apm310bm8wm7x5caa7-x265-2.9/bin/x265
shrinking /nix/store/71kbfhfmijf866apm310bm8wm7x5caa7-x265-2.9/lib/libx265.so.165
strip is /nix/store/53d3iay2ywwsfl0jzwm8pw7g8729h10g-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/71kbfhfmijf866apm310bm8wm7x5caa7-x265-2.9/lib  /nix/store/71kbfhfmijf866apm310bm8wm7x5caa7-x265-2.9/bin
patching script interpreter paths in /nix/store/71kbfhfmijf866apm310bm8wm7x5caa7-x265-2.9
checking for references to /build in /nix/store/71kbfhfmijf866apm310bm8wm7x5caa7-x265-2.9...
/nix/store/71kbfhfmijf866apm310bm8wm7x5caa7-x265-2.9

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: x265

Partial log (click to expand)

cannot build derivation '/nix/store/qpbbbl92gjway1njn0g4aq2mv1nlyhgl-perl5.28.0-XML-Parser-2.44.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/xzzm12k5chpk375hn9w7xw6gwwda1dbi-intltool-0.51.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/f6ijni633qhqchhm91ya3vydx40c6c35-gnome-doc-utils-0.20.10.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/6d6hhx13bgycscchwm93yk49jpv97gpg-shadow-4.6.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/6fp6dsa7b3ijakxnpfg3gmsi14kbjrwz-util-linux-2.32.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/3w5xjfc1knd1mfghqh7l4dgmnn5lmnpn-e2fsprogs-1.44.4.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/rhxwkn2p6axz03z8whq5yb87dgy7yqc9-libarchive-3.3.3.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/71vhbpzk3acz0mpxxkxq5i95mc3lblpi-cmake-3.12.1.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/31536wpcgnznjs1mv3g8w50av7spix7m-x265-2.9.drv': 4 dependencies couldn't be built
error: build of '/nix/store/31536wpcgnznjs1mv3g8w50av7spix7m-x265-2.9.drv' failed

@c0bw3b c0bw3b merged commit b82a493 into NixOS:staging Nov 15, 2018
@c0bw3b c0bw3b deleted the pkg/x265 branch November 16, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants